pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart - Issue 1507313006: dart2js cps: Add instruction for null checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

Issue 1507313006: dart2js cps: Add instruction for null checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix true/false misdocumentation about condition and do not emit call Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

diff --git a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

index 18bab391400d4d79f1b58ba5c603614e0932ff41..27305149f664ee4d896eb843da59b602e064f0fa 100644

--- a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

+++ b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

@@ -168,6 +168,16 @@ class PullIntoInitializers extends RecursiveTransformer

return node;

}

+ Statement visitNullCheck(NullCheck node) {

+ if (node.condition != null) {

+ node.condition = visitExpression(node.condition);

+ // The value occurs in conditional context, so don't pull from that.

+ } else {

+ node.value = visitExpression(node.value);

+ }

+ return node;

+ }

Expression visitAssign(Assign node) {

bool inImpureContext = impureCounter > 0;

bool inBranch = branchCounter > 0;