pkg/analysis_server/test/services/completion/completion_test_util.dart - Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_test_util.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart

index 4ea40091df3762ae7ffcac9a608973b828f2ac53..674c31d0c5b8ef5edb6e28743261776f2a15b12b 100644

--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart

+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart

@@ -3985,9 +3985,10 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

return computeFull((bool result) {

expect(request.replacementOffset, completionOffset);

expect(request.replacementLength, 0);

- assertSuggestInvocationClass('X');

- assertSuggestInvocationClass('Y');

- assertSuggestInvocationTopLevelVar('T1', null);

+ // Suggested by LibraryMemberContributor

+ assertNotSuggested('X');

+ assertNotSuggested('Y');

+ assertNotSuggested('T1');

assertNotSuggested('T2');

assertNotSuggested('Object');

assertNotSuggested('b');

@@ -4014,8 +4015,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

return computeFull((bool result) {

expect(request.replacementOffset, completionOffset);

expect(request.replacementLength, 0);

- assertSuggestInvocationClass('X');

- assertSuggestInvocationClass('Y');

+ // Suggested by LibraryMemberContributor

+ assertNotSuggested('X');

+ assertNotSuggested('Y');

assertNotSuggested('T1');

assertNotSuggested('T2');

assertNotSuggested('Object');

@@ -4043,8 +4045,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

return computeFull((bool result) {

expect(request.replacementOffset, completionOffset);

expect(request.replacementLength, 0);

- assertSuggestInvocationClass('X');

- assertSuggestInvocationClass('Y');

+ // Suggested by LibraryMemberContributor

+ assertNotSuggested('X');

+ assertNotSuggested('Y');

assertNotSuggested('T1');

assertNotSuggested('T2');

assertNotSuggested('Object');