pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index d895218c35aa4f873c043368af6ddf83fbb64121..c1949294a62a8d9315578dddeef60f2bf124cb0e 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -154,11 +154,7 @@ class DartCompletionRequestImpl extends CompletionRequestImpl

}

@override

- Future resolveIdentifier(SimpleIdentifier identifier) async {

- if (identifier.bestElement != null) {

- return;

- }

+ Future resolveExpression(Expression expression) async {

//TODO(danrubel) resolve the expression or containing method

// rather than the entire complilation unit