Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 15073003: Miscellaneous fixes for system libraries files: (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Miscellaneous fixes for system libraries files: - fix icu namespace ambiguity - fix undeclared variable in libvpx.gyp file - add gyp target for chromium zip code in the third_party directory BUG=226860 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M build/linux/unbundle/icu.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M build/linux/unbundle/libvpx.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/unbundle/zlib.gyp View 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-08 23:14:16 UTC) #1
Ryan Sleevi
lgtm
7 years, 7 months ago (2013-05-08 23:24:18 UTC) #2
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-08 23:31:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r199050 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698