Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: test/cctest/test-api.cc

Issue 1507273002: Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing metho… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index bd26f9277b4ad4d5142ad6e8daf65e5f264b582a..c5171e8cbf260e057da06dbd0fd3580d5f13db98 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -5612,7 +5612,7 @@ TEST(APIThrowMessageOverwrittenToString) {
static void check_custom_error_tostring(v8::Local<v8::Message> message,
v8::Local<v8::Value> data) {
- const char* uncaught_error = "Uncaught MyError toString";
+ const char* uncaught_error = "Uncaught my name: my message";
CHECK(message->Get()
->Equals(CcTest::isolate()->GetCurrentContext(),
v8_str(uncaught_error))
@@ -5630,9 +5630,6 @@ TEST(CustomErrorToString) {
" this.message = message; "
"} "
"MyError.prototype = Object.create(Error.prototype); "
- "MyError.prototype.toString = function() { "
- " return 'MyError toString'; "
- "}; "
"throw new MyError('my name', 'my message'); ");
context->GetIsolate()->RemoveMessageListeners(check_custom_error_tostring);
}
@@ -5694,7 +5691,7 @@ TEST(CustomErrorMessage) {
static void check_custom_rethrowing_message(v8::Local<v8::Message> message,
v8::Local<v8::Value> data) {
- const char* uncaught_error = "Uncaught exception";
+ const char* uncaught_error = "Uncaught [object Object]";
CHECK(message->Get()
->Equals(CcTest::isolate()->GetCurrentContext(),
v8_str(uncaught_error))

Powered by Google App Engine
This is Rietveld 408576698