Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing metho…

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 38d641dd99bfac3280f4b6185d74d44e2d9a042c..ddd87d5c41a885de27e5a2b60339d53c3856bab5 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -2898,12 +2898,16 @@ Local<String> Value::ToString(Isolate* isolate) const {
 
 
 MaybeLocal<String> Value::ToDetailString(Local<Context> context) const {

[Yang, 2015/12/08 14:38:15]

maybe we don't have to expose this anymore? Chrome does not use it.

-  auto obj = Utils::OpenHandle(this);
+  i::Handle<i::Object> obj = Utils::OpenHandle(this);
   if (obj->IsString()) return ToApiHandle<String>(obj);
   PREPARE_FOR_EXECUTION(context, "ToDetailString", String);
   Local<String> result;
-  has_pending_exception =
-      !ToLocal<String>(i::Execution::ToDetailString(isolate, obj), &result);
+  i::Handle<i::Object> args[] = {obj};
+  has_pending_exception = !ToLocal<String>(
+      i::Execution::TryCall(isolate, isolate->no_side_effects_to_string_fun(),
+                            isolate->factory()->undefined_value(),
+                            arraysize(args), args),
+      &result);
   RETURN_ON_FAILED_EXECUTION(String);
   RETURN_ESCAPED(result);
 }