Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 1507253003: [Cronet] Allow experimenting with Chrome's internal DNS resolver. (Closed)

Created:
4 years ago by pauljensen
Modified:
4 years ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nojson3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Allow experimenting with Chrome's internal DNS resolver. Enable by adding "AsyncDNS":{"enable":true} to experimental options. By default fallback to getaddrinfo() is enabled. Note that this is only for experimentation because: 1. It's never been used in production 2. It's likely not the desired long term solution on Android as it does not contribute to the O/S DNS cache. BUG=545123 Committed: https://crrev.com/e92c4096de6e0b7761e4e97850245948878c0446 Cr-Commit-Position: refs/heads/master@{#364117}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/url_request_context_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/url_request_context_config.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/cronet/url_request_context_config.cc View 1 2 5 chunks +29 lines, -4 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pauljensen
Helen, PTAL. I tested with the Cronet sample app and it seems to work. You ...
4 years ago (2015-12-09 17:17:14 UTC) #3
xunjieli
This is very cool! Don't have any useful comment. lgtm with nits. https://codereview.chromium.org/1507253003/diff/20001/components/cronet/url_request_context_config.cc File components/cronet/url_request_context_config.cc ...
4 years ago (2015-12-09 18:38:37 UTC) #4
pauljensen
https://codereview.chromium.org/1507253003/diff/20001/components/cronet/url_request_context_config.cc File components/cronet/url_request_context_config.cc (right): https://codereview.chromium.org/1507253003/diff/20001/components/cronet/url_request_context_config.cc#newcode7 components/cronet/url_request_context_config.cc:7: #include "base/basictypes.h" On 2015/12/09 18:38:37, xunjieli wrote: > Since ...
4 years ago (2015-12-09 18:51:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507253003/40001
4 years ago (2015-12-09 18:57:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2015-12-09 19:13:58 UTC) #10
commit-bot: I haz the power
4 years ago (2015-12-09 19:15:37 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e92c4096de6e0b7761e4e97850245948878c0446
Cr-Commit-Position: refs/heads/master@{#364117}

Powered by Google App Engine
This is Rietveld 408576698