Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: content/browser/background_sync/background_sync_service_impl.h

Issue 1507233003: Change BackgroundSyncContextImpl to use StrongBindingSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-geolocation-untangle
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_service_impl.h
diff --git a/content/browser/background_sync/background_sync_service_impl.h b/content/browser/background_sync/background_sync_service_impl.h
index 2557e9b5cec007468004d802312103214e1e1d07..19916ba2fdff0894a792be3aa8c855f1527aa886 100644
--- a/content/browser/background_sync/background_sync_service_impl.h
+++ b/content/browser/background_sync/background_sync_service_impl.h
@@ -6,22 +6,17 @@
#define CONTENT_BROWSER_BACKGROUND_SYNC_BACKGROUND_SYNC_SERVICE_IMPL_H_
#include "base/id_map.h"
-#include "base/memory/ref_counted.h"
#include "base/memory/scoped_vector.h"
#include "content/browser/background_sync/background_sync_manager.h"
#include "content/common/background_sync_service.mojom.h"
-#include "mojo/public/cpp/bindings/binding.h"
namespace content {
-class BackgroundSyncContextImpl;
-
class CONTENT_EXPORT BackgroundSyncServiceImpl
: public NON_EXPORTED_BASE(BackgroundSyncService) {
public:
- BackgroundSyncServiceImpl(
- BackgroundSyncContextImpl* background_sync_context,
- mojo::InterfaceRequest<BackgroundSyncService> request);
+ explicit BackgroundSyncServiceImpl(
+ BackgroundSyncManager* background_sync_manager);
~BackgroundSyncServiceImpl() override;
@@ -68,13 +63,7 @@ class CONTENT_EXPORT BackgroundSyncServiceImpl
BackgroundSyncStatus status,
BackgroundSyncState sync_state);
- // Called when an error is detected on binding_.
- void OnConnectionError();
-
- // background_sync_context_ owns this.
- BackgroundSyncContextImpl* background_sync_context_;
-
- mojo::Binding<BackgroundSyncService> binding_;
+ BackgroundSyncManager* const background_sync_manager_;
// The registrations that the client might reference.
IDMap<BackgroundSyncRegistrationHandle,

Powered by Google App Engine
This is Rietveld 408576698