Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150723006: Make input_methods.txt to be able to specify indicator string. (Closed)

Created:
6 years, 10 months ago by Junichi Uekawa
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Make input_methods.txt to be able to specify indicator string. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250642

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : rebase #

Patch Set 4 : fix unit tests #

Patch Set 5 : more consistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -125 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 4 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 3 4 8 chunks +41 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/ime/component_extension_ime_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/ime/gen_input_methods.py View 7 chunks +19 lines, -15 lines 0 comments Download
M chromeos/ime/input_method_descriptor.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chromeos/ime/input_method_descriptor.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/ime/input_method_whitelist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/ime/input_methods.txt View 1 2 3 3 chunks +60 lines, -58 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Junichi Uekawa
Hi, To move indicator string definition to .txt file this seems to be sufficient for ...
6 years, 10 months ago (2014-02-05 05:55:47 UTC) #1
Seigo Nonaka
lgtm lgtm, Thanks!
6 years, 10 months ago (2014-02-05 06:17:18 UTC) #2
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-10 00:22:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150723006/70001
6 years, 10 months ago (2014-02-10 00:22:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 00:38:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49153
6 years, 10 months ago (2014-02-10 00:38:53 UTC) #6
Junichi Uekawa
Hi, nkostylev: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc nona: everything else
6 years, 10 months ago (2014-02-10 00:49:08 UTC) #7
Nikita (slow)
/webui/options/chromeos/* lgtm
6 years, 10 months ago (2014-02-10 13:34:57 UTC) #8
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-10 23:05:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150723006/70001
6 years, 10 months ago (2014-02-10 23:08:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150723006/70001
6 years, 10 months ago (2014-02-10 23:57:41 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 02:09:16 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=200306
6 years, 10 months ago (2014-02-11 02:09:16 UTC) #13
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-12 01:59:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150723006/620001
6 years, 10 months ago (2014-02-12 02:00:35 UTC) #15
Junichi Uekawa
The CQ bit was unchecked by uekawa@chromium.org
6 years, 10 months ago (2014-02-12 03:47:07 UTC) #16
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-12 03:47:07 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 05:12:31 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cc_unittests, chrome_elf_unittests, chromedriver_unittests, ...
6 years, 10 months ago (2014-02-12 05:12:32 UTC) #19
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-12 05:16:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150723006/620001
6 years, 10 months ago (2014-02-12 05:19:06 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 07:32:30 UTC) #22
Message was sent while issue was closed. 
Change committed as 250642

Powered by Google App Engine
This is Rietveld 408576698