Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h

Issue 1507183002: MediaRecorder: update to spec (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased to http://crrev.com/1497883002 (just landed) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
index 1d1760d7ecb44688ec0da471ad4c623205e42e1c..130f99b8ff9b429ce96d111593be54251d47759d 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
@@ -9,6 +9,7 @@
#include "core/events/EventTarget.h"
#include "modules/EventTargetModules.h"
#include "modules/ModulesExport.h"
+#include "modules/mediarecorder/MediaRecorderOptions.h"
#include "modules/mediastream/MediaStream.h"
#include "platform/AsyncMethodRunner.h"
#include "public/platform/WebMediaRecorderHandler.h"
@@ -35,7 +36,7 @@ public:
};
static MediaRecorder* create(ExecutionContext*, MediaStream*, ExceptionState&);
- static MediaRecorder* create(ExecutionContext*, MediaStream*, const String& mimeType, ExceptionState&);
+ static MediaRecorder* create(ExecutionContext*, MediaStream*, const MediaRecorderOptions&, ExceptionState&);
virtual ~MediaRecorder() {}
@@ -59,7 +60,7 @@ public:
void resume(ExceptionState&);
void requestData(ExceptionState&);
- static String canRecordMimeType(const String& mimeType);
+ static bool isTypeSupported(const String& type);
// EventTarget
virtual const AtomicString& interfaceName() const override;
@@ -80,7 +81,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- MediaRecorder(ExecutionContext*, MediaStream*, const String& mimeType, ExceptionState&);
+ MediaRecorder(ExecutionContext*, MediaStream*, const MediaRecorderOptions&, ExceptionState&);
void createBlobEvent(Blob*);

Powered by Google App Engine
This is Rietveld 408576698