third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl - Issue 1507183002: MediaRecorder: update to spec (2/3)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

Issue 1507183002: MediaRecorder: update to spec (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/mediacapture-record/MediaRecorder.html
	Peter Beverloo 2015/12/10 20:28:53 append #MediaRecorderOptions, even though the patc append #MediaRecorderOptions, even though the patch hasn't made gh-pages yet? mcasas 2015/12/10 21:40:40 Just made it! http://w3c.github.io/mediacapture-re Show quoted text On 2015/12/10 20:28:53, Peter Beverloo wrote: > append #MediaRecorderOptions, even though the patch hasn't made gh-pages yet? Just made it! http://w3c.github.io/mediacapture-record/MediaRecorder.html has all the extra corrections of this patch and the previous https://codereview.chromium.org/1497883002/. Will update.
	6

	7 [

	8 GarbageCollected,
	Peter Beverloo 2015/12/10 20:28:53 [GC] doesn't do anything for dictionaries, they're [GC] doesn't do anything for dictionaries, they're completely auto-generated. mcasas 2015/12/10 21:40:40 Done. Show quoted text On 2015/12/10 20:28:53, Peter Beverloo wrote: > [GC] doesn't do anything for dictionaries, they're completely auto-generated. Done.
	9 ] dictionary MediaRecorderOptions {

	10 // TODO(mcasas): remove "mime" prefixes, https://github.com/w3c/mediacapture-r ecord/issues/10

	11 DOMString mimeType = ""; // Default encoding mimeType.

	12 unsigned long audioBitsPerSecond;
	Peter Beverloo 2015/12/10 20:28:53 I think it would be best if we don't mention these I think it would be best if we don't mention these types in the IDL yet until we support them. mcasas 2015/12/10 21:40:40 Done. Show quoted text On 2015/12/10 20:28:53, Peter Beverloo wrote: > I think it would be best if we don't mention these types in the IDL yet until we > support them. Done.
	13 unsigned long videoBitsPerSecond;

	14 unsigned long bitsPerSecond;

	15 };

OLD	NEW