Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507123002: default SkPixelSerializer (Closed)

Created:
5 years ago by hal.canary
Modified:
5 years ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

default SkPixelSerializer Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function. Add SkImageEncoder::CreatePixelSerializer() to return a PixelSerializer that calls into SkImageEncoder::EncodeData. SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer. Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce Committed: https://skia.googlesource.com/skia/+/f2848b60358deb23eca38a4587247c1d2e335d30

Patch Set 1 #

Patch Set 2 : SkImageDecoder_empty.cpp #

Patch Set 3 : one more time #

Patch Set 4 : 2015-12-09 (Wednesday) 11:13:45 EST #

Patch Set 5 : 2015-12-10 (Thursday) 13:15:57 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -52 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M include/core/SkImageEncoder.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 2 chunks +8 lines, -25 lines 0 comments Download
M src/images/SkImageEncoder.cpp View 1 2 3 4 2 chunks +28 lines, -2 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 1 2 3 4 3 chunks +18 lines, -0 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/sk_tool_utils.h View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 36 (18 generated)
hal.canary
PTAL
5 years ago (2015-12-07 23:04:35 UTC) #2
scroggo
lgtm
5 years ago (2015-12-08 15:37:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507123002/1
5 years ago (2015-12-08 16:57:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-08 17:14:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507123002/1
5 years ago (2015-12-08 17:15:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4490)
5 years ago (2015-12-08 17:18:16 UTC) #11
hal.canary
reed@, PTAL @ API. Leon has already 1GTMed it.
5 years ago (2015-12-08 17:19:48 UTC) #13
reed1
lgtm
5 years ago (2015-12-08 18:21:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507123002/1
5 years ago (2015-12-08 18:23:54 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b
5 years ago (2015-12-08 18:30:00 UTC) #18
reed1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1505203003/ by reed@google.com. ...
5 years ago (2015-12-08 18:59:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507123002/20001
5 years ago (2015-12-08 22:30:09 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce
5 years ago (2015-12-09 03:02:39 UTC) #24
hal.canary
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1511183002/ by halcanary@google.com. ...
5 years ago (2015-12-09 11:55:51 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507123002/120001
5 years ago (2015-12-10 18:16:50 UTC) #29
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 18:29:04 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507123002/120001
5 years ago (2015-12-10 20:39:38 UTC) #34
commit-bot: I haz the power
5 years ago (2015-12-10 20:40:30 UTC) #36
Message was sent while issue was closed. 
Committed patchset #5 (id:120001) as
https://skia.googlesource.com/skia/+/f2848b60358deb23eca38a4587247c1d2e335d30

Powered by Google App Engine
This is Rietveld 408576698