Plumb edit commands to plugins

Source/WebKit/chromium/src/WebFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1210 matching lines @@
     else if (command == "AdvanceToNextMisspelling") {
         // Wee need to pass false here or else the currently selected word will never be skipped.
         frame()->editor()->advanceToNextMisspelling(false);
     } else if (command == "ToggleSpellPanel")
         frame()->editor()->showSpellingGuessPanel();
     else
         result = frame()->editor()->command(command).execute();
     return result;
 }
 
-bool WebFrameImpl::executeCommand(const WebString& name, const WebString& value)
+bool WebFrameImpl::executeCommand(const WebString& name, const WebString& value, const WebNode& node)
 {
     ASSERT(frame());
     String webName = name;
 
+    WebPluginContainerImpl* pluginContainer = pluginContainerFromFrame(frame());
+    if (!pluginContainer)
+        pluginContainer = static_cast<WebPluginContainerImpl*>(node.pluginContainer());

[abarth-chromium, 2013/05/28 16:34:31]

Should we have an inline helper function that implements this pattern?  I see it
copy/pasted at least once on line 1200.  Generally whenever you find yourself
copy/pasting code, you should consider factoring that code out into a helper
function.

[Fady Samuel, 2013/05/29 04:40:06]

Done.

+    if (pluginContainer && pluginContainer->executeEditCommand(name, value))
+        return true;
+
     // moveToBeginningOfDocument and moveToEndfDocument are only handled by WebKit for editable nodes.
     if (!frame()->editor()->canEdit() && webName == "moveToBeginningOfDocument")
         return viewImpl()->propagateScroll(ScrollUp, ScrollByDocument);
 
     if (!frame()->editor()->canEdit() && webName == "moveToEndOfDocument")
         return viewImpl()->propagateScroll(ScrollDown, ScrollByDocument);
 
     return frame()->editor()->command(webName).execute(value);
 }
 
@@ skipping 1251 matching lines @@
 
         // There is a possibility that the frame being detached was the only
         // pending one. We need to make sure final replies can be sent.
         flushCurrentScopingEffort(m_findRequestIdentifier);
 
         cancelPendingScopingEffort();
     }
 }
 
 } // namespace WebKit