Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: components/scheduler/base/task_queue_manager_unittest.cc

Issue 1507093004: Adopt a less severe anti-starvation policy for immediate tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove skip for editing/spelling/spelling-huge-text-sync.html Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/base/task_queue_manager_unittest.cc
diff --git a/components/scheduler/base/task_queue_manager_unittest.cc b/components/scheduler/base/task_queue_manager_unittest.cc
index 6396d36238b0ad4580534d4d77c4f6c8076c8189..c490396968fc838103df48ff8a8553f87244d94b 100644
--- a/components/scheduler/base/task_queue_manager_unittest.cc
+++ b/components/scheduler/base/task_queue_manager_unittest.cc
@@ -1593,7 +1593,8 @@ bool ShouldExit(QuadraticTask* quadratic_task, LinearTask* linear_task) {
} // namespace
-TEST_F(TaskQueueManagerTest, DelayedTasksDontStarveNonDelayedWork_SameQueue) {
+TEST_F(TaskQueueManagerTest,
+ DelayedTasksDontBadlyStarveNonDelayedWork_SameQueue) {
Initialize(1u);
QuadraticTask quadratic_delayed_task(
@@ -1614,7 +1615,7 @@ TEST_F(TaskQueueManagerTest, DelayedTasksDontStarveNonDelayedWork_SameQueue) {
double ratio = static_cast<double>(linear_immediate_task.count()) /
static_cast<double>(quadratic_delayed_task.count());
- EXPECT_GT(ratio, 0.9);
+ EXPECT_GT(ratio, 0.333);
EXPECT_LT(ratio, 1.1);
}
@@ -1647,7 +1648,7 @@ TEST_F(TaskQueueManagerTest, ImmediateWorkCanStarveDelayedTasks_SameQueue) {
}
TEST_F(TaskQueueManagerTest,
- DelayedTasksDontStarveNonDelayedWork_DifferentQueue) {
+ DelayedTasksDontBadlyStarveNonDelayedWork_DifferentQueue) {
Initialize(2u);
QuadraticTask quadratic_delayed_task(
@@ -1668,7 +1669,7 @@ TEST_F(TaskQueueManagerTest,
double ratio = static_cast<double>(linear_immediate_task.count()) /
static_cast<double>(quadratic_delayed_task.count());
- EXPECT_GT(ratio, 0.9);
+ EXPECT_GT(ratio, 0.333);
EXPECT_LT(ratio, 1.1);
}
« no previous file with comments | « no previous file | components/scheduler/base/task_queue_selector.h » ('j') | components/scheduler/base/task_queue_selector.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698