Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: infra/services/mastermon/pollers.py

Issue 1507093003: mastermon: report step metrics (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/services/mastermon/test/pollers_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/services/mastermon/pollers.py
diff --git a/infra/services/mastermon/pollers.py b/infra/services/mastermon/pollers.py
index 369fb4114db42ef600a7b0f96c2aa0a6935a00f5..61f97d6a00875e30890b91665670c82d994f586e 100644
--- a/infra/services/mastermon/pollers.py
+++ b/infra/services/mastermon/pollers.py
@@ -141,6 +141,11 @@ class FilePoller(Poller):
total_times = ts_mon.CumulativeDistributionMetric(
'buildbot/master/builders/builds/total_durations', bucketer=bucketer)
+ step_result_count = ts_mon.CounterMetric(
+ 'buildbot/master/builders/steps/results/count')
+ step_times = ts_mon.CumulativeDistributionMetric(
+ 'buildbot/master/builders/steps/durations', bucketer=bucketer)
+
def poll(self):
LOGGER.info('Collecting results from %s', self._url)
@@ -173,3 +178,14 @@ class FilePoller(Poller):
self.pending_times.add(data['pending_s'], fields)
if 'total_s' in data:
self.total_times.add(data['total_s'], fields)
+
+ if 'steps' in data:
+ for step in data['steps']:
+ step_fields = copy.copy(fields)
+ step_fields.update({
+ 'step_name': step['step_name'],
+ 'result': step['result'],
+ })
+
+ self.step_result_count.increment(step_fields)
+ self.step_times.add(step['duration_s'], step_fields)
« no previous file with comments | « no previous file | infra/services/mastermon/test/pollers_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698