Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1507063007: try stifling integer overflow error (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

try stifling integer overflow error first time we've done this, let's see if it works! BUG=skia:4667 Looks ok now. Red ASAN bot is different errors. Committed: https://skia.googlesource.com/skia/+/7918b995060f413bb819c9ef1d350748b2bb7da9

Patch Set 1 #

Patch Set 2 : single underscore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/xsan.blacklist View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mtklein
lgtm
5 years ago (2015-12-09 15:06:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507063007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507063007/20001
5 years ago (2015-12-09 15:07:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot/builds/80)
5 years ago (2015-12-09 15:12:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507063007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507063007/20001
5 years ago (2015-12-09 15:17:56 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-09 15:24:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7918b995060f413bb819c9ef1d350748b2bb7da9

Powered by Google App Engine
This is Rietveld 408576698