Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507063004: Revert "Create direct write font proxy classes and unit tests." (Closed)

Created:
5 years ago by Lambros
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Create direct write font proxy classes and unit tests." This reverts commit 42290cb91a66566637a1715737b1961a8480b934. Caused content_unittests to fail on Win XP/Vista bots: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/41657 https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/62527 TBR=kulshin Committed: https://chromium.googlesource.com/chromium/src/+/d02ac68c6d429f96858ac9a5101f386db15811be

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2432 lines) Patch
D content/browser/renderer_host/dwrite_font_proxy_message_filter_win.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc View 1 chunk +0 lines, -345 lines 0 comments Download
D content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D content/child/dwrite_font_proxy/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.h View 1 chunk +0 lines, -30 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_win.h View 1 chunk +0 lines, -198 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc View 1 chunk +0 lines, -506 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc View 1 chunk +0 lines, -375 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_localized_strings_win.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_localized_strings_win.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -4 lines 0 comments Download
D content/common/dwrite_font_proxy_messages.h View 1 chunk +0 lines, -39 lines 0 comments Download
M content/common/font_warmup_win.h View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/font_warmup_win.cc View 2 chunks +50 lines, -50 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
D content/test/dwrite_font_fake_sender_win.h View 1 chunk +0 lines, -162 lines 0 comments Download
D content/test/dwrite_font_fake_sender_win.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -43 lines 0 comments Download
M ui/gfx/win/direct_write.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 3 chunks +13 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d02ac68c6d429f96858ac9a5101f386db15811be Cr-Commit-Position: refs/heads/master@{#363852}
5 years ago (2015-12-09 00:34:40 UTC) #3
Lambros
5 years ago (2015-12-09 00:35:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d02ac68c6d429f96858ac9a5101f386db15811be.

Powered by Google App Engine
This is Rietveld 408576698