One SkTSearch to rule them all. Allow key to be of different type than the array.

src/utils/win/SkWGL_win.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkWGL.h"
 
 #include "SkTDArray.h"
 #include "SkTSearch.h"
+#include "SkTSort.h"
 
 bool SkWGLExtensions::hasExtension(HDC dc, const char* ext) const {
     if (NULL == this->fGetExtensionsString) {
         return false;
     }
     if (!strcmp("WGL_ARB_extensions_string", ext)) {
         return true;
     }
     const char* extensionString = this->getExtensionsString(dc);
     int extLength = strlen(ext);
@@ skipping 53 matching lines @@
 
 namespace {
 
 struct PixelFormat {
     int fFormat;
     int fCoverageSamples;
     int fColorSamples;
     int fChoosePixelFormatRank;
 };
 
-int compare_pf(const PixelFormat* a, const PixelFormat* b) {
-    if (a->fCoverageSamples < b->fCoverageSamples) {
-        return -1;
-    } else if (b->fCoverageSamples < a->fCoverageSamples) {
-        return 1;
-    } else if (a->fColorSamples < b->fColorSamples) {
-        return -1;
-    } else if (b->fColorSamples < a->fColorSamples) {
-        return 1;
-    } else if (a->fChoosePixelFormatRank < b->fChoosePixelFormatRank) {
-        return -1;
-    } else if (b->fChoosePixelFormatRank < a->fChoosePixelFormatRank) {
-        return 1;
+bool pf_less(const PixelFormat& a, const PixelFormat& b) {
+    if (a.fCoverageSamples < b.fCoverageSamples) {
+        return true;
+    } else if (b.fCoverageSamples < a.fCoverageSamples) {
+        return false;
+    } else if (a.fColorSamples < b.fColorSamples) {
+        return true;
+    } else if (b.fColorSamples < a.fColorSamples) {
+        return false;
+    } else if (a.fChoosePixelFormatRank < b.fChoosePixelFormatRank) {
+        return true;
     }
-    return 0;
+    return false;
 }
 }
 
 int SkWGLExtensions::selectFormat(const int formats[],
                                   int formatCount,
                                   HDC dc,
                                   int desiredSampleCount) {
     PixelFormat desiredFormat = {
         0,
         desiredSampleCount,
@@ skipping 18 matching lines @@
                                      formats[i],
                                      0,
                                      queryAttrCnt,
                                      queryAttrs,
                                      answers);
         rankedFormats[i].fFormat =  formats[i];
         rankedFormats[i].fCoverageSamples = answers[0];
         rankedFormats[i].fColorSamples = answers[supportsCoverage ? 1 : 0];
         rankedFormats[i].fChoosePixelFormatRank = i;
     }
-    qsort(rankedFormats.begin(),
-            rankedFormats.count(),
-            sizeof(PixelFormat),
-            SkCastForQSort(compare_pf));
-    int idx = SkTSearch<PixelFormat>(rankedFormats.begin(),
-                                     rankedFormats.count(),
-                                     desiredFormat,
-                                     sizeof(PixelFormat),
-                                     compare_pf);
+    SkTQSort(rankedFormats.begin(),
+             rankedFormats.begin() + rankedFormats.count() - 1,
+             SkTLessFunctionToFunctorAdaptor<PixelFormat, pf_less>());
+    int idx = SkTSearch<PixelFormat, pf_less>(rankedFormats.begin(),
+                                              rankedFormats.count(),
+                                              desiredFormat,
+                                              sizeof(PixelFormat));
     if (idx < 0) {
         idx = ~idx;
     }
     return rankedFormats[idx].fFormat;
 }
 
 
 namespace {
 
 #if defined(UNICODE)
@@ skipping 204 matching lines @@
     }
 
     if (NULL == glrc) {
         glrc = wglCreateContext(dc);
     }
     SkASSERT(glrc);
 
     wglMakeCurrent(prevDC, prevGLRC);
     return glrc;
 }