One SkTSearch to rule them all. Allow key to be of different type than the array.

src/sfnt/SkOTTable_name.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkOTTable_name.h"
 
 #include "SkEndian.h"
@@ skipping 413 matching lines @@
     { 0x4409, "en-MY" }, //English
     { 0x440a, "es-SV" }, //Spanish
     { 0x4809, "en-SG" }, //English
     { 0x480a, "es-HN" }, //Spanish
     { 0x4c0a, "es-NI" }, //Spanish
     { 0x500a, "es-PR" }, //Spanish
     { 0x540a, "es-US" }, //Spanish
 };
 
 namespace {
-int BCP47FromLanguageIdCompare(const BCP47FromLanguageId* a, const BCP47FromLanguageId* b) {
-    return a->languageID - b->languageID;
+bool BCP47FromLanguageIdLess(const BCP47FromLanguageId& a, const BCP47FromLanguageId& b) {
+    return a.languageID < b.languageID;
 }
 }
 
 bool SkOTTableName::Iterator::next(SkOTTableName::Iterator::Record& record) {
     const size_t nameRecordsCount = SkEndian_SwapBE16(fName.count);
     const SkOTTableName::Record* nameRecords = SkTAfter<const SkOTTableName::Record>(&fName);
     const SkOTTableName::Record* nameRecord;
 
     // Find the next record which matches the requested type.
     do {
@@ skipping 56 matching lines @@
             uint16_t offset = SkEndian_SwapBE16(languageTagRecord[languageTagRecordIndex].offset);
             uint16_t length = SkEndian_SwapBE16(languageTagRecord[languageTagRecordIndex].length);
             const uint16_t* string = SkTAddOffset<const uint16_t>(stringTable, offset);
             SkStringFromUTF16BE(string, length, record.language);
             return true;
         }
     }
 
     // Handle format 0 languages, translating them into BCP 47.
     const BCP47FromLanguageId target = { languageID, "" };
-    int languageIndex = SkTSearch<BCP47FromLanguageId, BCP47FromLanguageIdCompare>(
+    int languageIndex = SkTSearch<BCP47FromLanguageId, BCP47FromLanguageIdLess>(
         BCP47FromLanguageID, SK_ARRAY_COUNT(BCP47FromLanguageID), target, sizeof(target));
     if (languageIndex >= 0) {
         record.language = BCP47FromLanguageID[languageIndex].bcp47;
         return true;
     }
 
     // Unknown language, return the BCP 47 code 'und' for 'undetermined'.
     SkASSERT(false);
     record.language = "und";
     return true;
 }