Cleanup CSSPropertyParser some more

Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/566fec8e26a99c602281bf85f727e7d17bbde3d4
Cr-Commit-Position: refs/heads/master@{#363709}

[rwlbuis, 2015-12-07 21:33:53]

Description was changed from

==========
Cleanup

BUG=
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some methods from Legacy to CSSPropertyParser.cpp.

BUG=499780
==========

[rwlbuis, 2015-12-07 21:35:26]

Description was changed from

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some methods from Legacy to CSSPropertyParser.cpp.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in
the header (for now).
- move trivial properties order, image-orientation.

BUG=499780
==========

[rwlbuis, 2015-12-07 21:36:49]

Description was changed from

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in
the header (for now).
- move trivial properties order, image-orientation.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now).
- move simple properties order, opacity, -webkit-box-flex and image-orientation.

BUG=499780
==========

[rwlbuis, 2015-12-07 21:47:04]

Description was changed from

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now).
- move simple properties order, opacity, -webkit-box-flex and image-orientation.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.
- move simple properties order, opacity, -webkit-box-flex and image-orientation.

BUG=499780
==========

[rwlbuis, 2015-12-07 21:48:26]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-12-07 21:48:26]

PTAL. I hope it is okay that I lump some stuff together.

[Timothy Loh, 2015-12-07 22:52:36]

On 2015/12/07 21:48:26, rwlbuis wrote:
> PTAL. I hope it is okay that I lump some stuff together.

lgtm aside from moving properties across, I'd rather we kept that separate.

[rwlbuis, 2015-12-07 22:59:29]

On 2015/12/07 22:52:36, Timothy Loh wrote:
> On 2015/12/07 21:48:26, rwlbuis wrote:
> > PTAL. I hope it is okay that I lump some stuff together.
> 
> lgtm aside from moving properties across, I'd rather we kept that separate.

Sure, I'll remove that part, thanks.

[rwlbuis, 2015-12-07 23:15:07]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-12-07 23:15:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1506983002/#ps40001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-12-07 23:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506983002/40001

[rwlbuis, 2015-12-07 23:32:21]

Description was changed from

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.
- move simple properties order, opacity, -webkit-box-flex and image-orientation.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2015-12-07 23:32:28]

The CQ bit was unchecked by rob.buis@samsung.com

[rwlbuis, 2015-12-07 23:32:37]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-12-07 23:39:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506983002/40001

[commit-bot: I haz the power, 2015-12-08 00:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 00:11:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rwlbuis, 2015-12-08 00:55:03]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-12-08 00:58:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506983002/40001

[commit-bot: I haz the power, 2015-12-08 02:19:38]

Description was changed from

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.

BUG=499780
==========

[commit-bot: I haz the power, 2015-12-08 02:19:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-08 02:21:16]

Description was changed from

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser some more

This CL cleans up CSSPropertyParser as follows:

- make more parsing methods static.
- move some independent methods from Legacy to CSSPropertyParser.cpp.
- rename isGeneratedImageValue to isGeneratedImage and put it in the
  header (for now) since it is shared between Legacy and CSSPropertyParser.

BUG=499780

Committed: https://crrev.com/566fec8e26a99c602281bf85f727e7d17bbde3d4
Cr-Commit-Position: refs/heads/master@{#363709}
==========

[commit-bot: I haz the power, 2015-12-08 02:21:18]

Patchset 3 (id:??) landed as
https://crrev.com/566fec8e26a99c602281bf85f727e7d17bbde3d4
Cr-Commit-Position: refs/heads/master@{#363709}