Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1506963002: Options processing API update (#25126). (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Options processing API update (#25126). Updates processing API to accept untyped options maps. Required to support processing options merged from embedders and local analysis options. See: https://github.com/dart-lang/sdk/issues/25126 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ee310b6aff6e0844f3ffafd1b240fae38612b77c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/plugin/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/plugin/plugin_configuration.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-07 19:07:12 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-07 19:15:16 UTC) #3
pquitslund
5 years ago (2015-12-07 19:27:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee310b6aff6e0844f3ffafd1b240fae38612b77c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698