Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: test/webkit/fast/js/JSON-parse-reviver-expected.txt

Issue 1506933003: JSON.parse: properly deal with reviver result (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/webkit/fast/js/JSON-parse-reviver.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/webkit/fast/js/JSON-parse-reviver-expected.txt
diff --git a/test/webkit/fast/js/JSON-parse-reviver-expected.txt b/test/webkit/fast/js/JSON-parse-reviver-expected.txt
index c68efa417be8304de4e0659c39ad4602fcac099c..bcd9e5a0811bba3756715900e1e8776ad0e3a178 100644
--- a/test/webkit/fast/js/JSON-parse-reviver-expected.txt
+++ b/test/webkit/fast/js/JSON-parse-reviver-expected.txt
@@ -46,7 +46,7 @@ Ensure that we always get the same holder
PASS currentHolder is lastHolder
Ensure that returning undefined has removed the property 0 from the holder during filtering.
-FAIL currentHolder.hasOwnProperty(0) should be false. Was true.
+PASS currentHolder.hasOwnProperty(0) is false
Ensure the holder for our array is indeed an array
PASS Array.isArray(currentHolder) is true
@@ -76,18 +76,19 @@ PASS value is undefined.
Ensure the holder for our array is indeed an array
PASS Array.isArray(currentHolder) is true
-FAIL currentHolder.length should be 3. Was 4.
+PASS currentHolder.length is 4
Ensure that we always get the same holder
PASS currentHolder is lastHolder
-FAIL Did not call reviver for deleted property
+PASS Ensured that property was visited despite Array length being reduced.
+PASS value is undefined.
Ensure that we created the root holder as specified in ES5
PASS '' in lastHolder is true
PASS result is lastHolder['']
Ensure that a deleted value is revived if the reviver function returns a value
-FAIL result.hasOwnProperty(3) should be true. Was false.
+PASS result.hasOwnProperty(3) is true
Test behaviour of revivor used in conjunction with an object
PASS currentHolder != globalObject is true
@@ -113,11 +114,21 @@ PASS currentHolder['and another property'] is "a replaced value"
Ensure that the changed value is reflected in the arguments passed to the reviver
PASS value is "a replaced value"
+PASS currentHolder != globalObject is true
+
+Ensure that we get the same holder object for each property
+PASS currentHolder is lastHolder
+
+Ensure that we visited a value that we have deleted, and that deletion is reflected while filtering.
+PASS currentHolder.hasOwnProperty('to delete') is false
+
+Ensure that when visiting a deleted property value is undefined
+PASS value is undefined.
Ensure that we created the root holder as specified in ES5
PASS lastHolder.hasOwnProperty('') is true
PASS result.hasOwnProperty('a property') is false
-FAIL result.hasOwnProperty('to delete') should be true. Was false.
+PASS result.hasOwnProperty('to delete') is true
PASS result is lastHolder['']
Test behaviour of revivor that introduces a cycle
« no previous file with comments | « test/webkit/fast/js/JSON-parse-reviver.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698