Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506913002: Pin result in SkATan2_255 (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Take 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/effects/gradients/SkSweepGradient.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
robertphillips
5 years ago (2015-12-07 17:06:17 UTC) #1
robertphillips
5 years ago (2015-12-07 17:06:30 UTC) #4
robertphillips
Revised - PTAL
5 years ago (2015-12-07 17:28:31 UTC) #5
reed1
lgtm
5 years ago (2015-12-07 17:30:05 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506913002/20001
5 years ago (2015-12-07 17:31:31 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 17:45:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506913002/20001
5 years ago (2015-12-07 17:53:30 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-07 17:54:05 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1d265ca85f51ea1ba087ca4d0f80b008c256a47d

Powered by Google App Engine
This is Rietveld 408576698