Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1506903003: PPC: [ic] Change CompareIC to handle JSReceiver instead of JSObject. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [ic] Change CompareIC to handle JSReceiver instead of JSObject. Port 0ed0878041574382b75d4d549f3ff73afcc72efb Original commit message: There's no reason to limit the CompareIC to (known) JSObject instances, as all JSReceivers behave the same wrt. abstract and strict equality. So remove this historical limitation and track JSReceivers instead. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/873fcd1450badf74a2285a2b0e56a5cd0c9625b1 Cr-Commit-Position: refs/heads/master@{#32665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506903003/1
5 years ago (2015-12-07 21:33:28 UTC) #2
MTBrandyberry
5 years ago (2015-12-07 21:33:43 UTC) #3
john.yan
lgtm
5 years ago (2015-12-07 22:15:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 22:15:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506903003/1
5 years ago (2015-12-07 22:29:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 22:30:35 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-07 22:31:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/873fcd1450badf74a2285a2b0e56a5cd0c9625b1
Cr-Commit-Position: refs/heads/master@{#32665}

Powered by Google App Engine
This is Rietveld 408576698