Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1506903002: [turbofan] context and function deopt inputs are on the stack. (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] context and function deopt inputs are on the stack. Deoptimization expects the context and function marker on the stack. To let the register allocator control spilling of the live ranges corresponding to these 2 operands, we need their use to be represented accurately. BUG=v8:4533 LOG=N Committed: https://crrev.com/6dc8eb67f4ef7781c5c7b0f3a8cefcddf0b81db2 Cr-Commit-Position: refs/heads/master@{#32666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/compiler/instruction-selector.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mircea Trofin
5 years ago (2015-12-07 17:27:00 UTC) #3
Jarin
lgtm
5 years ago (2015-12-07 22:18:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506903002/1
5 years ago (2015-12-07 22:20:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8632)
5 years ago (2015-12-07 22:24:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506903002/1
5 years ago (2015-12-07 22:59:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 23:02:32 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-07 23:03:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dc8eb67f4ef7781c5c7b0f3a8cefcddf0b81db2
Cr-Commit-Position: refs/heads/master@{#32666}

Powered by Google App Engine
This is Rietveld 408576698