Issue 15069003: Rename the embedded test server to EmbeddedTestServer in net::test_server namespace.

Issue 15069003: Rename the embedded test server to EmbeddedTestServer in net::test_server namespace. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.

Modified:
7 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename the embedded test server to EmbeddedTestServer in net::test_server namespace. This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199229

Patch Set 1 #

Patch Set 2 : interactive_ui_tests #

Total comments: 2

Patch Set 3 : nit #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+301 lines, -894 lines)			Patch
M	chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/kiosk_browsertest.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/oobe_browsertest.cc	View	1	5 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/api/streams_private/streams_private_apitest.cc	View		8 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/google_apis/base_operations_server_unittest.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_operations_unittest.cc	View		36 chunks	+60 lines, -60 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_operations_unittest.cc	View		46 chunks	+64 lines, -64 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.h	View		4 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.cc	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	net/net.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	net/test/embedded_test_server/embedded_test_server.h	View		8 chunks	+22 lines, -21 lines	0 comments	Download
A +	net/test/embedded_test_server/embedded_test_server.cc	View		13 chunks	+30 lines, -27 lines	0 comments	Download
A +	net/test/embedded_test_server/embedded_test_server_unittest.cc	View		9 chunks	+51 lines, -50 lines	0 comments	Download
M	net/test/embedded_test_server/http_connection.h	View		4 chunks	+5 lines, -6 lines	0 comments	Download
M	net/test/embedded_test_server/http_connection.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/test/embedded_test_server/http_request.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/test/embedded_test_server/http_request.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/test/embedded_test_server/http_request_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/test/embedded_test_server/http_response.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/test/embedded_test_server/http_response.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/test/embedded_test_server/http_response_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	net/test/embedded_test_server/http_server.h	View		1 chunk	+0 lines, -161 lines	0 comments	Download
D	net/test/embedded_test_server/http_server.cc	View		1 chunk	+0 lines, -213 lines	0 comments	Download
D	net/test/embedded_test_server/http_server_unittest.cc	View		1 chunk	+0 lines, -223 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

One tiny nit. LGTM otherwise. https://codereview.chromium.org/15069003/diff/3001/net/test/embedded_test_server/http_response.h File net/test/embedded_test_server/http_response.h (right): https://codereview.chromium.org/15069003/diff/3001/net/test/embedded_test_server/http_response.h#newcode68 net/test/embedded_test_server/http_response.h:68: } // namespace test_servers ...

7 years, 7 months ago (2013-05-08 22:19:40 UTC) #2

Paweł Hajdan Jr.

https://codereview.chromium.org/15069003/diff/3001/net/test/embedded_test_server/http_response.h File net/test/embedded_test_server/http_response.h (right): https://codereview.chromium.org/15069003/diff/3001/net/test/embedded_test_server/http_response.h#newcode68 net/test/embedded_test_server/http_response.h:68: } // namespace test_servers On 2013/05/08 22:19:40, Ryan Hamilton ...

7 years, 7 months ago (2013-05-08 23:44:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r199229.

Expand Messages | Collapse Messages