Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 1506893004: [net] Make state table const to share between processes. (Closed)

Created:
5 years ago by Daniel Bratell
Modified:
5 years ago
Reviewers:
yhirano, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net] Make state table const to share between processes. When studying the contents of the duplicated data between processes I found the parser_state variable in http_server.cc. It's only about 200 bytes but the fix is trivial (add a const). The rest of the change is a git cl format net to make presubmit happy. R=yhirano@chromium.org, mmenke@chromium.org BUG= Committed: https://crrev.com/d852b022fc0a650c94cc92b0af907e45acf46f22 Cr-Commit-Position: refs/heads/master@{#364061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M net/server/http_server.cc View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Daniel Bratell
It would have been one line hadn't the presubmit made me reformat the code.
5 years ago (2015-12-09 10:55:09 UTC) #2
yhirano
lgtm
5 years ago (2015-12-09 11:45:35 UTC) #3
mmenke
LGTM. Thanks for doing this! Everything adds up, and it really should have been const ...
5 years ago (2015-12-09 13:55:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506893004/1
5 years ago (2015-12-09 14:33:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 14:39:19 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 14:40:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d852b022fc0a650c94cc92b0af907e45acf46f22
Cr-Commit-Position: refs/heads/master@{#364061}

Powered by Google App Engine
This is Rietveld 408576698