Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1506883004: Fixes incorrect values seen in clip property (Closed)

Created:
5 years ago by Zachary Forman
Modified:
5 years ago
Reviewers:
dstockwell
CC:
blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes incorrect values seen in clip property Previously getComputedStyle(el).clip would be 'box: 0 0 0 0' when the element's clip was 'rect(auto, auto, auto, auto)'. This change corrects the behaviour so that each side of the box is considered correctly (i.e. as rect(auto auto auto auto)), even the box as a whole is not 'auto'. Firefox displays rect(auto, auto, auto, auto) in the case where rect(auto, auto, auto, auto) is used, and rect(auto, X, auto, Y) where rect(auto, X, auto, Y) is used. Our behavior now matches that. BUG=412921 Committed: https://crrev.com/19c08f5cdff2046ee2fd143c3582c2e5994fb7aa Cr-Commit-Position: refs/heads/master@{#363747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-clip.html View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Zachary Forman
Hi, could you please review this cl? Thanks, Zac
5 years ago (2015-12-08 02:16:36 UTC) #2
dstockwell
On 2015/12/08 at 02:16:36, zforman wrote: > Hi, could you please review this cl? > ...
5 years ago (2015-12-08 02:43:38 UTC) #3
Zachary Forman
Have done.
5 years ago (2015-12-08 04:01:25 UTC) #7
dstockwell
lgtm
5 years ago (2015-12-08 04:09:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506883004/1
5 years ago (2015-12-08 04:10:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 05:30:01 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-08 05:30:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19c08f5cdff2046ee2fd143c3582c2e5994fb7aa
Cr-Commit-Position: refs/heads/master@{#363747}

Powered by Google App Engine
This is Rietveld 408576698