Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1506823004: Remove drawPathsFromRange from GrDrawContext (Closed)

Created:
5 years ago by Chris Dalton
Modified:
5 years ago
CC:
reviews_skia.org, nv_mark
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove drawPathsFromRange from GrDrawContext Replaces drawPathsFromRange with a more general drawPathBatch method. While this still isn't perfect, it's a step in the right direction that removes the need for path range draws to fit in a public API. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8ff8d24c83353fc421177886d82202da9ff89234

Patch Set 1 #

Patch Set 2 : Rebase error #

Patch Set 3 : rebase #

Patch Set 4 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -118 lines) Patch
M include/gpu/GrDrawContext.h View 3 chunks +9 lines, -13 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +10 lines, -16 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 3 chunks +5 lines, -29 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +3 lines, -30 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 6 chunks +18 lines, -11 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 2 chunks +4 lines, -16 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Chris Dalton
This is needed for https://codereview.chromium.org/1507203002/
5 years ago (2015-12-08 07:49:59 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-08 14:57:05 UTC) #3
Chris Dalton
Oops I had a stupid rebase error in patchset #1. Committing now.
5 years ago (2015-12-08 17:11:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506823004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506823004/20001
5 years ago (2015-12-08 17:12:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot/builds/73) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years ago (2015-12-08 17:12:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506823004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506823004/60001
5 years ago (2015-12-08 18:02:48 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-08 18:20:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8ff8d24c83353fc421177886d82202da9ff89234

Powered by Google App Engine
This is Rietveld 408576698