Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1506813002: LayoutTests: remove tests for Object.observe (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
adamk
CC:
chromium-reviews, tim+watch_chromium.org, caseq+blink_chromium.org, zea+watch_chromium.org, pfeldman+blink_chromium.org, maxbogue+watch_chromium.org, lushnikov+blink_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: remove tests for Object.observe In preparation for the feature to be un-shipped. BUG=chromium:552100 Committed: https://crrev.com/09cdd70ba13b91c967bba0e3391d05fc1281ee32 Cr-Commit-Position: refs/heads/master@{#364163}

Patch Set 1 #

Messages

Total messages: 11 (3 generated)
Jakob Kummerow
Thought I'd help a bit with the O.o dependency removal. PTAL. Feel free to CQ ...
5 years ago (2015-12-07 12:17:14 UTC) #2
adamk
On 2015/12/07 12:17:14, Jakob wrote: > Thought I'd help a bit with the O.o dependency ...
5 years ago (2015-12-07 19:05:17 UTC) #3
Jakob Kummerow
On 2015/12/07 19:05:17, adamk wrote: > I'd prefer to leave these tests in until Object.observe ...
5 years ago (2015-12-07 21:12:51 UTC) #4
adamk
On 2015/12/07 21:12:51, Jakob wrote: > On 2015/12/07 19:05:17, adamk wrote: > > I'd prefer ...
5 years ago (2015-12-08 01:23:45 UTC) #5
adamk
Actually, I think you're right that removing these makes more sense than skipping them (since ...
5 years ago (2015-12-09 20:18:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506813002/1
5 years ago (2015-12-09 20:20:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 21:43:30 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 21:44:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09cdd70ba13b91c967bba0e3391d05fc1281ee32
Cr-Commit-Position: refs/heads/master@{#364163}

Powered by Google App Engine
This is Rietveld 408576698