Replace CSS Variables tests from Gecko with the tests Gecko uploaded to csswg-test

Replace CSS Variables tests from Gecko with the tests Gecko uploaded to csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
Committed: https://crrev.com/6796327f3f41ed8c782582efab8d3739f32545c4
Cr-Commit-Position: refs/heads/master@{#372617}

[kojii, 2015-12-07 14:47:45]

kojii@chromium.org changed reviewers:
+ leviw@chromium.org

[kojii, 2015-12-07 14:47:47]

Hi Levi,

I found you imported Gecko's variables tests, which is also available at:
https://github.com/w3c/csswg-test/tree/master/vendor-imports/mozilla/mozilla-...

We can import them through csswg-test, and I thought it's good as it has some
minor updates such as:
https://github.com/w3c/csswg-test/commit/95c7fe12f044f244e27e26a3b0e4eef4ed3a...

But as you see in this CL, I'm seeing crashes. I don't see real differences:
https://codereview.chromium.org/1506793002/diff/20001/third_party/WebKit/Layo...
except that "support/ahem.css" is missing in your imported tests while it is
available in imported tests.

WDYT? Was that intentional not to import ahem.css?

[leviw_travelin_and_unemployed, 2015-12-07 18:41:48]

On 2015/12/07 at 14:47:47, kojii wrote:
> Hi Levi,
> 
> I found you imported Gecko's variables tests, which is also available at:
>
https://github.com/w3c/csswg-test/tree/master/vendor-imports/mozilla/mozilla-...
> 
> We can import them through csswg-test, and I thought it's good as it has some
minor updates such as:
>
https://github.com/w3c/csswg-test/commit/95c7fe12f044f244e27e26a3b0e4eef4ed3a...
> 
> But as you see in this CL, I'm seeing crashes. I don't see real differences:
>
https://codereview.chromium.org/1506793002/diff/20001/third_party/WebKit/Layo...
> except that "support/ahem.css" is missing in your imported tests while it is
available in imported tests.
> 
> WDYT? Was that intentional not to import ahem.css?

I'm confused... There certainly seems to be an imported ahem.css to me. I have
it in my checkout. Here it is in the tree:
https://blink.lc/chromium/tree/third_party/WebKit/LayoutTests/imported/gecko/...

[leviw_travelin_and_unemployed, 2015-12-07 18:43:15]

On 2015/12/07 at 14:47:47, kojii wrote:
> Hi Levi,
> 
> I found you imported Gecko's variables tests, which is also available at:
>
https://github.com/w3c/csswg-test/tree/master/vendor-imports/mozilla/mozilla-...
> 
> We can import them through csswg-test, and I thought it's good as it has some
minor updates such as:
>
https://github.com/w3c/csswg-test/commit/95c7fe12f044f244e27e26a3b0e4eef4ed3a...
> 
> But as you see in this CL, I'm seeing crashes. I don't see real differences:

Where are there crashes? I don't see any crashes.

>
https://codereview.chromium.org/1506793002/diff/20001/third_party/WebKit/Layo...
> except that "support/ahem.css" is missing in your imported tests while it is
available in imported tests.
> 
> WDYT? Was that intentional not to import ahem.css?

[kojii, 2015-12-08 02:18:32]

On 2015/12/07 18:43:15, leviw wrote:
> > except that "support/ahem.css" is missing in your imported tests while it is
> available in imported tests.
> > 
> > WDYT? Was that intentional not to import ahem.css?

Yeah, but the tests has <link href="../support/ahem.css"> so it's not loaded.

> > But as you see in this CL, I'm seeing crashes. I don't see real differences:
> 
> Where are there crashes? I don't see any crashes.

From the bot results:
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

[leviw_travelin_and_unemployed, 2015-12-08 03:36:43]

leviw@chromium.org changed reviewers:
+ shans@chromium.org

[leviw_travelin_and_unemployed, 2015-12-08 03:36:44]

On 2015/12/08 at 02:18:32, kojii wrote:
> On 2015/12/07 18:43:15, leviw wrote:
> > > except that "support/ahem.css" is missing in your imported tests while it
is
> > available in imported tests.
> > > 
> > > WDYT? Was that intentional not to import ahem.css?
> 
> Yeah, but the tests has <link href="../support/ahem.css"> so it's not loaded.

That's definitely a mistake, and a surprising one. The tests were moved around a
few times -- apparently they weren't properly updated in one of the moves.

> 
> > > But as you see in this CL, I'm seeing crashes. I don't see real
differences:
> > 
> > Where are there crashes? I don't see any crashes.
> 
> From the bot results:
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

I guess I looked at the Win results, which just had a bunch of PNG failures, not
crashes.

I have no idea about those crashes, but the stacks look messed up. Something
weird is going on. I suspect someone needs to try these locally to understand
the issue.

Shans@ is taking the reins on CSS Variables now, so you should coordinate with
him on how to proceed.

[kojii, 2015-12-08 06:55:56]

On 2015/12/08 03:36:44, leviw wrote:
> On 2015/12/08 at 02:18:32, kojii wrote:
> > On 2015/12/07 18:43:15, leviw wrote:
> > > > except that "support/ahem.css" is missing in your imported tests while
it
> is
> > > available in imported tests.
> > > > 
> > > > WDYT? Was that intentional not to import ahem.css?
> > 
> > Yeah, but the tests has <link href="../support/ahem.css"> so it's not
loaded.
> 
> That's definitely a mistake, and a surprising one. The tests were moved around
a
> few times -- apparently they weren't properly updated in one of the moves.
> 
> > 
> > > > But as you see in this CL, I'm seeing crashes. I don't see real
> differences:
> > > 
> > > Where are there crashes? I don't see any crashes.
> > 
> > From the bot results:
> >
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
> 
> I guess I looked at the Win results, which just had a bunch of PNG failures,
not
> crashes.
> 
> I have no idea about those crashes, but the stacks look messed up. Something
> weird is going on. I suspect someone needs to try these locally to understand
> the issue.
> 
> Shans@ is taking the reins on CSS Variables now, so you should coordinate with
> him on how to proceed.

Win seems to have failed to run, Linux has unreadable stack always for me, Mac
had one:
STDERR: [18495:1287:1207/055910:2209851053456:FATAL:file_path.cc(485)] Check
failed: !IsPathAbsolute(appended). 
STDERR: 0   Content Shell Framework             0x000000010a3069e3
_ZN4base5debug10StackTraceC1Ev + 19
STDERR: 1   Content Shell Framework             0x000000010a31f0a9
_ZN7logging10LogMessageD2Ev + 73
STDERR: 2   Content Shell Framework             0x000000010a30b682
_ZNK4base8FilePath6AppendENS_16BasicStringPieceINSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEEE
+ 290
STDERR: 3   Content Shell Framework             0x000000010a30c7ed
_ZNK4base8FilePath6AppendERKS0_ + 45
STDERR: 4   Content Shell Framework             0x000000010dc20cfe
_ZN11test_runner17TestInfoExtractor11GetNextTestEv + 1246
STDERR: 5   Content Shell Framework             0x000000010a1d29af
_Z21LayoutTestBrowserMainRKN7content18MainFunctionParamsERK10scoped_ptrINS_17BrowserMainRunnerENSt3__114default_deleteIS4_EEE
+ 847
STDERR: 6   Content Shell Framework             0x000000010a1b30a9
_ZN7content17ShellMainDelegate10RunProcessERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEERKNS_18MainFunctionParamsE
+ 201
STDERR: 7   Content Shell Framework             0x000000010a1f5ed3
_ZN7content23RunNamedProcessTypeMainERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEERKNS_18MainFunctionParamsEPNS_19ContentMainDelegateE
+ 227
STDERR: 8   Content Shell Framework             0x000000010a1f687a
_ZN7content21ContentMainRunnerImpl3RunEv + 266
STDERR: 9   Content Shell Framework             0x000000010a1f5c36
_ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
STDERR: 10  Content Shell Framework             0x000000010a1b1b42 ContentMain +
66
STDERR: 11  Content Shell                       0x000000010a1adf24 start + 52
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...

It looks like it's failing to write log file, huh...let's see if re-running the
bots would change.

[leviw_travelin_and_unemployed, 2016-01-27 23:35:23]

Looking at win_chromium_rel_ng, these seem to be passing (despite the bot being
red...)

[kojii, 2016-01-28 00:26:23]

On 2016/01/27 23:35:23, leviw wrote:
> Looking at win_chromium_rel_ng, these seem to be passing (despite the bot
being
> red...)

Yeah, they're flaky ones.

Mac failures are more strange, failing in
test_runner::TestInfoExtractor::GetNextTestEv, looks like imported tests have
something that the test runner do not like. I'll re-run bots.

[leviw_travelin_and_unemployed, 2016-02-01 00:18:50]

Looks like some genuine failures?

imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-18.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-15.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-font-face-01.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-16.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-reference-37.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-reference-36.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-font-face-02.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-declaration-17.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-reference-40.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-reference-12.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-reference-38.html
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-external-font-face-01.html

[kojii, 2016-02-01 00:51:11]

On 2016/02/01 at 00:18:50, leviw wrote:
> Looks like some genuine failures?

Looks like importer or test_runner issue, crashes on Mac bot has stacktrace:
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...

STDERR: _ZN4base5debug10StackTraceC1Ev + 19
STDERR: _ZN7logging10LogMessageD2Ev + 73
STDERR:
_ZNK4base8FilePath6AppendENS_16BasicStringPieceINSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEEE
+ 290
STDERR: _ZNK4base8FilePath6AppendERKS0_ + 45
STDERR: _ZN11test_runner17TestInfoExtractor11GetNextTestEv + 1275

So probably importer does something test_runner dislikes, but haven't figured
out what it is yet.

[kojii, 2016-02-01 05:05:09]

Description was changed from

==========
WIP: Move CSS Variables tests

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=
==========

to

==========
WIP: Move CSS Variables tests

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

[kojii, 2016-02-01 06:30:15]

Description was changed from

==========
WIP: Move CSS Variables tests

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

to

==========
Replace CSS Variables Tests from Gecko with the one Gecko uploaded to csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

[kojii, 2016-02-01 06:31:15]

kojii@chromium.org changed reviewers:
+ timloh@chromium.org

[kojii, 2016-02-01 06:31:17]

PTAL. Turned out most issues are in test importer, bug two failures are real.

[kojii, 2016-02-01 06:36:43]

Description was changed from

==========
Replace CSS Variables Tests from Gecko with the one Gecko uploaded to csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

to

==========
Replace CSS Variables Tests from Gecko with the tests Gecko uploaded to
csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

[kojii, 2016-02-01 06:36:57]

Description was changed from

==========
Replace CSS Variables Tests from Gecko with the tests Gecko uploaded to
csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

to

==========
Replace CSS Variables tests from Gecko with the tests Gecko uploaded to
csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

[leviw_travelin_and_unemployed, 2016-02-01 06:42:06]

Woot woot! LGTM :)

[kojii, 2016-02-01 07:03:34]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-02-01 07:04:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506793002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506793002/80001

[commit-bot: I haz the power, 2016-02-01 07:18:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-01 07:19:31]

Description was changed from

==========
Replace CSS Variables tests from Gecko with the tests Gecko uploaded to
csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836
==========

to

==========
Replace CSS Variables tests from Gecko with the tests Gecko uploaded to
csswg-test

This patch replaces CSS Variables tests we imported from Gecko in
crbug.com/465126 to the one Gecko uploaded to csswg-test and enable
update-w3c-deps to import this test.

The tests were slightly updated since it was last imported and there
are two new failures marked in TestExpectations.

crbug.com/582838 requires to skip all files named "reftest.list". This
is done in W3CImportExpectations until the bug is fixed.

Import csswg-test@668f1adc1f47a9046cff49340c68b1d96a4b8c31

Using update-w3c-deps in Blink bea6db8f479197b92152f6b098225abc75784e67.

BUG=582836

Committed: https://crrev.com/6796327f3f41ed8c782582efab8d3739f32545c4
Cr-Commit-Position: refs/heads/master@{#372617}
==========

[commit-bot: I haz the power, 2016-02-01 07:19:33]

Patchset 5 (id:??) landed as
https://crrev.com/6796327f3f41ed8c782582efab8d3739f32545c4
Cr-Commit-Position: refs/heads/master@{#372617}