Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 1506783003: ServiceWorker: Reject TypeError instead of SecurityError. (Closed)

Created:
5 years ago by zino
Modified:
5 years ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Reject TypeError instead of SecurityError. Should reject TypeError instead of SecurityError in openWindow(). This change is a followup CL of http://crrev.com/1481523006 to match the spec[1]. [1] http://slightlyoff.github.io/ServiceWorker/spec/service_worker BUG=540503 Committed: https://crrev.com/beba959fc5adb273b6d450c208ff25cf20abbaac Cr-Commit-Position: refs/heads/master@{#363958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
zino
PTAL.
5 years ago (2015-12-08 02:52:07 UTC) #3
nhiroki
lgtm
5 years ago (2015-12-08 08:57:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506783003/1
5 years ago (2015-12-08 08:59:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/95199) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-08 09:33:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506783003/1
5 years ago (2015-12-08 09:46:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/139622)
5 years ago (2015-12-08 10:09:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506783003/1
5 years ago (2015-12-08 11:48:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/98563)
5 years ago (2015-12-08 12:16:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506783003/1
5 years ago (2015-12-09 01:35:33 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 03:06:34 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-09 03:08:13 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beba959fc5adb273b6d450c208ff25cf20abbaac
Cr-Commit-Position: refs/heads/master@{#363958}

Powered by Google App Engine
This is Rietveld 408576698