Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1506763002: [turbofan] Always load context from target when lowering to direct call. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Always load context from target when lowering to direct call. There's no benefit in embedding the context as a constant for direct calls. In fact it seems to be cheaper both size and execution wise to just always load the context from the target. R=jarin@chromium.org Committed: https://crrev.com/277091ba90a88adf33227fbed58fc83301f2bce7 Cr-Commit-Position: refs/heads/master@{#32640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-07 05:31:57 UTC) #1
Benedikt Meurer
Hey Jaro, Small refactoring; helps a bit with reducing literals in deopt data. Please take ...
5 years ago (2015-12-07 05:36:06 UTC) #2
Jarin
lgtm
5 years ago (2015-12-07 06:16:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506763002/1
5 years ago (2015-12-07 06:19:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 06:21:05 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 06:22:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/277091ba90a88adf33227fbed58fc83301f2bce7
Cr-Commit-Position: refs/heads/master@{#32640}

Powered by Google App Engine
This is Rietveld 408576698