test/cctest/compiler/test-machine-operator-reducer.cc - Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-machine-operator-reducer.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/test-machine-operator-reducer.cc

diff --git a/test/cctest/compiler/test-machine-operator-reducer.cc b/test/cctest/compiler/test-machine-operator-reducer.cc

index ca49369592f816cf9f4c3bfe24dfacbaab0d0398..ac93c5230d7dca9880887d2497360e0224b160c5 100644

--- a/test/cctest/compiler/test-machine-operator-reducer.cc

+++ b/test/cctest/compiler/test-machine-operator-reducer.cc

@@ -362,7 +362,7 @@ TEST(ReduceWord32Sar) {

static void CheckJsShift(ReducerTester* R) {

- DCHECK(R->machine.Word32ShiftIsSafe());

+ CHECK(R->machine.Word32ShiftIsSafe());

Node* x = R->Parameter(0);

Node* y = R->Parameter(1);

« no previous file with comments | « test/cctest/compiler/test-loop-analysis.cc ('k') | test/cctest/compiler/test-multiple-return.cc » ('j') | no next file with comments »