Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: test/cctest/compiler/graph-builder-tester.h

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/c-signature.h ('k') | test/cctest/compiler/test-instruction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/graph-builder-tester.h
diff --git a/test/cctest/compiler/graph-builder-tester.h b/test/cctest/compiler/graph-builder-tester.h
index ea2c3ad13939dc66a61b05bf2c8667232d8d3fef..c1684d1ba0dbef6971a8da93e370ed98a264ad1d 100644
--- a/test/cctest/compiler/graph-builder-tester.h
+++ b/test/cctest/compiler/graph-builder-tester.h
@@ -68,7 +68,7 @@ class GraphBuilderTester : public HandleAndZoneScope,
void GenerateCode() { Generate(); }
Node* Parameter(size_t index) {
- DCHECK(index < parameter_count());
+ CHECK_LT(index, parameter_count());
return parameters_[index];
}
@@ -77,7 +77,7 @@ class GraphBuilderTester : public HandleAndZoneScope,
// Initialize graph and builder.
void Begin(int num_parameters) {
- DCHECK(graph()->start() == NULL);
+ CHECK_NULL(graph()->start());
Node* start = graph()->NewNode(common()->Start(num_parameters + 3));
graph()->SetStart(start);
effect_ = start;
@@ -235,15 +235,15 @@ class GraphBuilderTester : public HandleAndZoneScope,
protected:
Node* MakeNode(const Operator* op, int value_input_count,
Node** value_inputs) {
- DCHECK(op->ValueInputCount() == value_input_count);
+ CHECK_EQ(op->ValueInputCount(), value_input_count);
- DCHECK(!OperatorProperties::HasContextInput(op));
- DCHECK_EQ(0, OperatorProperties::GetFrameStateInputCount(op));
+ CHECK(!OperatorProperties::HasContextInput(op));
+ CHECK_EQ(0, OperatorProperties::GetFrameStateInputCount(op));
bool has_control = op->ControlInputCount() == 1;
bool has_effect = op->EffectInputCount() == 1;
- DCHECK(op->ControlInputCount() < 2);
- DCHECK(op->EffectInputCount() < 2);
+ CHECK_LT(op->ControlInputCount(), 2);
+ CHECK_LT(op->EffectInputCount(), 2);
Node* result = NULL;
if (!has_control && !has_effect) {
« no previous file with comments | « test/cctest/compiler/c-signature.h ('k') | test/cctest/compiler/test-instruction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698