[test] Test expectations in cctest should use CHECK and not DCHECK.

test/cctest/test-transitions.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(mythria): Remove this define after this flag is turned on globally
 #define V8_IMMINENT_DEPRECATION_WARNINGS
 
 #include <stdlib.h>
 #include <utility>
 
@@ skipping 69 matching lines @@
   CHECK_EQ(*map2,
            TransitionArray::SearchTransition(*map0, kData, *name2, attributes));
   CHECK_EQ(2, TransitionArray::NumberOfTransitions(map0->raw_transitions()));
   for (int i = 0; i < 2; i++) {
     Name* key = TransitionArray::GetKey(map0->raw_transitions(), i);
     Map* target = TransitionArray::GetTarget(map0->raw_transitions(), i);
     CHECK((key == *name1 && target == *map1) ||
           (key == *name2 && target == *map2));
   }
 
-  DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+  CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
 }
 
 
 TEST(TransitionArray_FullFieldTransitions) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
 
   Handle<String> name1 = factory->InternalizeUtf8String("foo");
@@ skipping 28 matching lines @@
   CHECK_EQ(*map2,
            TransitionArray::SearchTransition(*map0, kData, *name2, attributes));
   CHECK_EQ(2, TransitionArray::NumberOfTransitions(map0->raw_transitions()));
   for (int i = 0; i < 2; i++) {
     Name* key = TransitionArray::GetKey(map0->raw_transitions(), i);
     Map* target = TransitionArray::GetTarget(map0->raw_transitions(), i);
     CHECK((key == *name1 && target == *map1) ||
           (key == *name2 && target == *map2));
   }
 
-  DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+  CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
 }
 
 
 TEST(TransitionArray_DifferentFieldNames) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
 
   const int PROPS_COUNT = 10;
@@ skipping 26 matching lines @@
     Name* key = TransitionArray::GetKey(map0->raw_transitions(), i);
     Map* target = TransitionArray::GetTarget(map0->raw_transitions(), i);
     for (int j = 0; j < PROPS_COUNT; j++) {
       if (*names[i] == key) {
         CHECK_EQ(*maps[i], target);
         break;
       }
     }
   }
 
-  DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+  CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
 }
 
 
 TEST(TransitionArray_SameFieldNamesDifferentAttributesSimple) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
 
   Handle<Map> map0 = Map::Create(isolate, 0);
@@ skipping 20 matching lines @@
   // Ensure that transitions for |name| field are valid.
   for (int i = 0; i < ATTRS_COUNT; i++) {
     PropertyAttributes attributes = static_cast<PropertyAttributes>(i);
     CHECK_EQ(*attr_maps[i], TransitionArray::SearchTransition(
                                 *map0, kData, *name, attributes));
     // All transitions use the same key, so this check doesn't need to
     // care about ordering.
     CHECK_EQ(*name, TransitionArray::GetKey(map0->raw_transitions(), i));
   }
 
-  DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+  CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
 }
 
 
 TEST(TransitionArray_SameFieldNamesDifferentAttributes) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
 
   const int PROPS_COUNT = 10;
@@ skipping 57 matching lines @@
     } else {
       for (int j = 0; j < PROPS_COUNT; j++) {
         if (*names[j] == key) {
           CHECK_EQ(*maps[j], target);
           break;
         }
       }
     }
   }
 
-  DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+  CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
 }