[test] Test expectations in cctest should use CHECK and not DCHECK.

test/cctest/test-macro-assembler-x64.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 181 matching lines @@
   __ Move(rdx, Smi::FromInt(y));
   __ movq(r9, rdx);
   __ SmiCompare(rcx, rdx);
   if (x < y) {
     __ movl(rax, Immediate(id + 1));
     __ j(greater_equal, exit);
   } else if (x > y) {
     __ movl(rax, Immediate(id + 2));
     __ j(less_equal, exit);
   } else {
-    DCHECK_EQ(x, y);
+    CHECK_EQ(x, y);
     __ movl(rax, Immediate(id + 3));
     __ j(not_equal, exit);
   }
   __ movl(rax, Immediate(id + 4));
   __ cmpq(rcx, r8);
   __ j(not_equal, exit);
   __ incq(rax);
   __ cmpq(rdx, r9);
   __ j(not_equal, exit);
 
   if (x != y) {
     __ SmiCompare(rdx, rcx);
     if (y < x) {
       __ movl(rax, Immediate(id + 9));
       __ j(greater_equal, exit);
     } else {
-      DCHECK(y > x);
+      CHECK(y > x);
       __ movl(rax, Immediate(id + 10));
       __ j(less_equal, exit);
     }
   } else {
     __ cmpq(rcx, rcx);
     __ movl(rax, Immediate(id + 11));
     __ j(not_equal, exit);
     __ incq(rax);
     __ cmpq(rcx, r8);
     __ j(not_equal, exit);
@@ skipping 151 matching lines @@
   CHECK_EQ(0, result);
 }
 
 
 void TestI64PlusConstantToSmi(MacroAssembler* masm,
                               Label* exit,
                               int id,
                               int64_t x,
                               int y) {
   int64_t result = x + y;
-  DCHECK(Smi::IsValid(result));
+  CHECK(Smi::IsValid(result));
   __ movl(rax, Immediate(id));
   __ Move(r8, Smi::FromInt(static_cast<int>(result)));
   __ movq(rcx, x);
   __ movq(r11, rcx);
   __ Integer64PlusConstantToSmi(rdx, rcx, y);
   __ cmpq(rdx, r8);
   __ j(not_equal, exit);
 
   __ incq(rax);
   __ cmpq(r11, rcx);
@@ skipping 369 matching lines @@
   __ cmpq(rcx, r8);
   __ j(not_equal, exit);
 }
 
 
 static void SmiAddOverflowTest(MacroAssembler* masm,
                                Label* exit,
                                int id,
                                int x) {
   // Adds a Smi to x so that the addition overflows.
-  DCHECK(x != 0);  // Can't overflow by adding a Smi.
+  CHECK(x != 0);  // Can't overflow by adding a Smi.
   int y_max = (x > 0) ? (Smi::kMaxValue + 0) : (Smi::kMinValue - x - 1);
   int y_min = (x > 0) ? (Smi::kMaxValue - x + 1) : (Smi::kMinValue + 0);
 
   __ movl(rax, Immediate(id));
   __ Move(rcx, Smi::FromInt(x));
   __ movq(r11, rcx);  // Store original Smi value of x in r11.
   __ Move(rdx, Smi::FromInt(y_min));
   {
     Label overflow_ok;
     __ SmiAdd(r9, rcx, rdx, &overflow_ok);
@@ skipping 194 matching lines @@
   __ cmpq(rcx, r8);
   __ j(not_equal, exit);
 }
 
 
 static void SmiSubOverflowTest(MacroAssembler* masm,
                                Label* exit,
                                int id,
                                int x) {
   // Subtracts a Smi from x so that the subtraction overflows.
-  DCHECK(x != -1);  // Can't overflow by subtracting a Smi.
+  CHECK(x != -1);  // Can't overflow by subtracting a Smi.
   int y_max = (x < 0) ? (Smi::kMaxValue + 0) : (Smi::kMinValue + 0);
   int y_min = (x < 0) ? (Smi::kMaxValue + x + 2) : (Smi::kMinValue + x);
 
   __ movl(rax, Immediate(id));
   __ Move(rcx, Smi::FromInt(x));
   __ movq(r11, rcx);  // Store original Smi value of x in r11.
   __ Move(rdx, Smi::FromInt(y_min));
   {
     Label overflow_ok;
     __ SmiSub(r9, rcx, rdx, &overflow_ok);
@@ skipping 447 matching lines @@
   CHECK_EQ(0, result);
 }
 
 
 void TestSmiIndex(MacroAssembler* masm, Label* exit, int id, int x) {
   __ movl(rax, Immediate(id));
 
   for (int i = 0; i < 8; i++) {
     __ Move(rcx, Smi::FromInt(x));
     SmiIndex index = masm->SmiToIndex(rdx, rcx, i);
-    DCHECK(index.reg.is(rcx) || index.reg.is(rdx));
+    CHECK(index.reg.is(rcx) || index.reg.is(rdx));
     __ shlq(index.reg, Immediate(index.scale));
     __ Set(r8, static_cast<intptr_t>(x) << i);
     __ cmpq(index.reg, r8);
     __ j(not_equal, exit);
     __ incq(rax);
     __ Move(rcx, Smi::FromInt(x));
     index = masm->SmiToIndex(rcx, rcx, i);
-    DCHECK(index.reg.is(rcx));
+    CHECK(index.reg.is(rcx));
     __ shlq(rcx, Immediate(index.scale));
     __ Set(r8, static_cast<intptr_t>(x) << i);
     __ cmpq(rcx, r8);
     __ j(not_equal, exit);
     __ incq(rax);
 
     __ Move(rcx, Smi::FromInt(x));
     index = masm->SmiToNegativeIndex(rdx, rcx, i);
-    DCHECK(index.reg.is(rcx) || index.reg.is(rdx));
+    CHECK(index.reg.is(rcx) || index.reg.is(rdx));
     __ shlq(index.reg, Immediate(index.scale));
     __ Set(r8, static_cast<intptr_t>(-x) << i);
     __ cmpq(index.reg, r8);
     __ j(not_equal, exit);
     __ incq(rax);
     __ Move(rcx, Smi::FromInt(x));
     index = masm->SmiToNegativeIndex(rcx, rcx, i);
-    DCHECK(index.reg.is(rcx));
+    CHECK(index.reg.is(rcx));
     __ shlq(rcx, Immediate(index.scale));
     __ Set(r8, static_cast<intptr_t>(-x) << i);
     __ cmpq(rcx, r8);
     __ j(not_equal, exit);
     __ incq(rax);
   }
 }
 
 
 TEST(SmiIndex) {
@@ skipping 660 matching lines @@
 
   CodeDesc desc;
   masm->GetCode(&desc);
   // Call the function from C++.
   int result = FUNCTION_CAST<F0>(buffer)();
   CHECK_EQ(0, result);
 }
 
 
 void TestPositiveSmiPowerUp(MacroAssembler* masm, Label* exit, int id, int x) {
-  DCHECK(x >= 0);
+  CHECK(x >= 0);
   int powers[] = { 0, 1, 2, 3, 8, 16, 24, 31 };
   int power_count = 8;
   __ movl(rax, Immediate(id));
   for (int i = 0; i  < power_count; i++) {
     int power = powers[i];
     intptr_t result = static_cast<intptr_t>(x) << power;
     __ Set(r8, result);
     __ Move(rcx, Smi::FromInt(x));
     __ movq(r11, rcx);
     __ PositiveSmiTimesPowerOfTwoToInteger64(rdx, rcx, power);
@@ skipping 545 matching lines @@
 
   CodeDesc desc;
   masm->GetCode(&desc);
   // Call the function from C++.
   int result = FUNCTION_CAST<F0>(buffer)();
   CHECK_EQ(0, result);
 }
 
 
 #undef __