Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: test/cctest/test-disasm-arm64.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-assembler-mips64.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 1595
1596 COMPARE(nop(), "nop"); 1596 COMPARE(nop(), "nop");
1597 1597
1598 CLEANUP(); 1598 CLEANUP();
1599 } 1599 }
1600 1600
1601 1601
1602 TEST_(debug) { 1602 TEST_(debug) {
1603 SET_UP_ASM(); 1603 SET_UP_ASM();
1604 1604
1605 DCHECK(kImmExceptionIsDebug == 0xdeb0); 1605 CHECK(kImmExceptionIsDebug == 0xdeb0);
1606 1606
1607 // All debug codes should produce the same instruction, and the debug code 1607 // All debug codes should produce the same instruction, and the debug code
1608 // can be any uint32_t. 1608 // can be any uint32_t.
1609 COMPARE(debug("message", 0, BREAK), "hlt #0xdeb0"); 1609 COMPARE(debug("message", 0, BREAK), "hlt #0xdeb0");
1610 COMPARE(debug("message", 1, BREAK), "hlt #0xdeb0"); 1610 COMPARE(debug("message", 1, BREAK), "hlt #0xdeb0");
1611 COMPARE(debug("message", 0xffff, BREAK), "hlt #0xdeb0"); 1611 COMPARE(debug("message", 0xffff, BREAK), "hlt #0xdeb0");
1612 COMPARE(debug("message", 0x10000, BREAK), "hlt #0xdeb0"); 1612 COMPARE(debug("message", 0x10000, BREAK), "hlt #0xdeb0");
1613 COMPARE(debug("message", 0x7fffffff, BREAK), "hlt #0xdeb0"); 1613 COMPARE(debug("message", 0x7fffffff, BREAK), "hlt #0xdeb0");
1614 COMPARE(debug("message", 0x80000000u, BREAK), "hlt #0xdeb0"); 1614 COMPARE(debug("message", 0x80000000u, BREAK), "hlt #0xdeb0");
1615 COMPARE(debug("message", 0xffffffffu, BREAK), "hlt #0xdeb0"); 1615 COMPARE(debug("message", 0xffffffffu, BREAK), "hlt #0xdeb0");
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
1755 COMPARE(Dsb(FullSystem, BarrierOther), "dsb sy (0b1100)"); 1755 COMPARE(Dsb(FullSystem, BarrierOther), "dsb sy (0b1100)");
1756 COMPARE(Dsb(InnerShareable, BarrierOther), "dsb sy (0b1000)"); 1756 COMPARE(Dsb(InnerShareable, BarrierOther), "dsb sy (0b1000)");
1757 COMPARE(Dsb(NonShareable, BarrierOther), "dsb sy (0b0100)"); 1757 COMPARE(Dsb(NonShareable, BarrierOther), "dsb sy (0b0100)");
1758 COMPARE(Dsb(OuterShareable, BarrierOther), "dsb sy (0b0000)"); 1758 COMPARE(Dsb(OuterShareable, BarrierOther), "dsb sy (0b0000)");
1759 1759
1760 // ISB 1760 // ISB
1761 COMPARE(Isb(), "isb"); 1761 COMPARE(Isb(), "isb");
1762 1762
1763 CLEANUP(); 1763 CLEANUP();
1764 } 1764 }
OLDNEW
« no previous file with comments | « test/cctest/test-assembler-mips64.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698