Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: test/cctest/compiler/test-instruction.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(jochen): Remove this after the setting is turned on globally. 5 // TODO(jochen): Remove this after the setting is turned on globally.
6 #define V8_IMMINENT_DEPRECATION_WARNINGS 6 #define V8_IMMINENT_DEPRECATION_WARNINGS
7 7
8 #include "src/compiler/code-generator.h" 8 #include "src/compiler/code-generator.h"
9 #include "src/compiler/common-operator.h" 9 #include "src/compiler/common-operator.h"
10 #include "src/compiler/graph.h" 10 #include "src/compiler/graph.h"
(...skipping 28 matching lines...) Expand all
39 CommonOperatorBuilder common; 39 CommonOperatorBuilder common;
40 MachineOperatorBuilder machine; 40 MachineOperatorBuilder machine;
41 TestInstrSeq* code; 41 TestInstrSeq* code;
42 42
43 Zone* zone() { return main_zone(); } 43 Zone* zone() { return main_zone(); }
44 44
45 void allocCode() { 45 void allocCode() {
46 if (schedule.rpo_order()->size() == 0) { 46 if (schedule.rpo_order()->size() == 0) {
47 // Compute the RPO order. 47 // Compute the RPO order.
48 Scheduler::ComputeSpecialRPO(main_zone(), &schedule); 48 Scheduler::ComputeSpecialRPO(main_zone(), &schedule);
49 DCHECK(schedule.rpo_order()->size() > 0); 49 CHECK_NE(0u, schedule.rpo_order()->size());
50 } 50 }
51 InstructionBlocks* instruction_blocks = 51 InstructionBlocks* instruction_blocks =
52 TestInstrSeq::InstructionBlocksFor(main_zone(), &schedule); 52 TestInstrSeq::InstructionBlocksFor(main_zone(), &schedule);
53 code = new (main_zone()) 53 code = new (main_zone())
54 TestInstrSeq(main_isolate(), main_zone(), instruction_blocks); 54 TestInstrSeq(main_isolate(), main_zone(), instruction_blocks);
55 } 55 }
56 56
57 Node* Int32Constant(int32_t val) { 57 Node* Int32Constant(int32_t val) {
58 Node* node = graph.NewNode(common.Int32Constant(val)); 58 Node* node = graph.NewNode(common.Int32Constant(val));
59 schedule.AddNode(schedule.start(), node); 59 schedule.AddNode(schedule.start(), node);
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 CHECK(temps[z].Equals(*m->TempAt(z))); 320 CHECK(temps[z].Equals(*m->TempAt(z)));
321 } 321 }
322 } 322 }
323 } 323 }
324 } 324 }
325 } 325 }
326 326
327 } // namespace compiler 327 } // namespace compiler
328 } // namespace internal 328 } // namespace internal
329 } // namespace v8 329 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/compiler/graph-builder-tester.h ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698