pylib/gyp/MSVSUtil.py - Issue 1506733002: GYP: Make GYP build deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/MSVSUtil.py

Issue 1506733002: GYP: Make GYP build deterministic (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Fixes cosmetic issue Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/MSVSUtil.py

diff --git a/pylib/gyp/MSVSUtil.py b/pylib/gyp/MSVSUtil.py

index 0b32e911807844b87179d26ca5c98da3ad1a2223..f5e0c1d8b7632a5608793318a3f71fad34a09375 100644

--- a/pylib/gyp/MSVSUtil.py

+++ b/pylib/gyp/MSVSUtil.py

@@ -110,7 +110,7 @@ def ShardTargets(target_list, target_dicts):

else:

new_target_dicts[t] = target_dicts[t]

# Shard dependencies.

- for t in new_target_dicts:

+ for t in sorted(new_target_dicts):

for deptype in ('dependencies', 'dependencies_original'):

dependencies = copy.copy(new_target_dicts[t].get(deptype, []))

new_dependencies = []

« no previous file with comments | « no previous file | pylib/gyp/generator/ninja.py » ('j') | no next file with comments »