Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pylib/gyp/common.py

Issue 1506733002: GYP: Make GYP build deterministic (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: All tested Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/generator/ninja.py » ('j') | pylib/gyp/input.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/common.py
diff --git a/pylib/gyp/common.py b/pylib/gyp/common.py
index 256e3f3a6b2400f13c1b85c7e6f9668a258a1b95..cdf8fb353a0122b439cc575b0e1f420b764c04b8 100644
--- a/pylib/gyp/common.py
+++ b/pylib/gyp/common.py
@@ -111,6 +111,11 @@ def BuildFile(fully_qualified_target):
return ParseQualifiedTarget(fully_qualified_target)[0]
+def OrderDeterministically(l, **kwargs):
Nico 2015/12/10 20:30:24 I'd just call sorted() directly everywhere. if som
Zachary Forman 2015/12/30 02:18:43 Yeah, seems reasonable. I've swapped it back to so
+ """ Sorts l so that it is ordered deterministically. """
+ return sorted(l, **kwargs)
+
+
def GetEnvironFallback(var_list, default):
"""Look up a key in the environment, with fallback to secondary keys
and finally falling back to a default value."""
« no previous file with comments | « no previous file | pylib/gyp/generator/ninja.py » ('j') | pylib/gyp/input.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698