pylib/gyp/ninja_syntax.py - Issue 1506733002: GYP: Make GYP build deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/ninja_syntax.py

Issue 1506733002: GYP: Make GYP build deterministic (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Shrinks test case down, more thorough testing. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/ninja_syntax.py

diff --git a/pylib/gyp/ninja_syntax.py b/pylib/gyp/ninja_syntax.py

index d2948f06c08e36a8347a04bedc807413e0fbc05f..74c5651ce821d0d6a772d804e8e8191385c057d5 100644

--- a/pylib/gyp/ninja_syntax.py

+++ b/pylib/gyp/ninja_syntax.py

@@ -67,6 +67,9 @@ class Writer(object):

out_outputs = list(map(escape_path, outputs))

all_inputs = list(map(escape_path, all_inputs))

+ # Sort the inputs so our output is deterministic.

+ all_inputs.sort()

Nico 2015/12/09 20:25:00 i think callers should do this. this script is jus

Zachary Forman 2015/12/30 02:18:43 I think you're probably right, I've changed this t

if implicit:

implicit = map(escape_path, self._as_list(implicit))

all_inputs.append('|')

« no previous file with comments | « pylib/gyp/input.py ('k') | test/determinism/determinism.gyp » ('j') | no next file with comments »