Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(83)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/determinism/solib.cc
Issue
1506733002
:
GYP: Make GYP build deterministic (Closed)
Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Fixes cosmetic issue
Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pylib/gyp/MSVSUtil.py
pylib/gyp/generator/ninja.py
pylib/gyp/input.py
test/determinism/determinism.gyp
test/determinism/empty-targets.gyp
test/determinism/gyptest-determinism.py
test/determinism/gyptest-empty-target-names.py
test/determinism/gyptest-needed-variables.py
test/determinism/gyptest-solibs.py
test/determinism/main.cc
test/determinism/needed-variables.gyp
test/determinism/rule.py
test/determinism/solib.cc
test/determinism/solibs.gyp
View unified diff
|
Download patch
« no previous file with comments
|
« test/determinism/rule.py
('k') |
test/determinism/solibs.gyp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 #ifdef _MSC_VER
1 #ifdef _MSC_VER
2 __declspec(dllexport)
2 __declspec(dllexport)
3 #else
3 #else
4 __attribute__((visibility("default")))
4 __attribute__((visibility("default")))
5 #endif
5 #endif
6 int foo() {
6 int foo() {
7 return 42;
7 return 42;
8 }
8 }
OLD
NEW
« no previous file with comments
|
« test/determinism/rule.py
('k') |
test/determinism/solibs.gyp »
('j') |
no next file with comments »
Issue 1506733002: GYP: Make GYP build deterministic (Closed)
Created 5 years ago by Zachary Forman
Modified 4 years, 11 months ago
Reviewers: mithro-old, scottmg, Nico
Base URL: https://chromium.googlesource.com/external/gyp.git@master
Comments: 20
This is Rietveld
408576698
Chromium Code Reviews
Issue 1506733002:
GYP: Make GYP build deterministic (Closed)
Base URL: https://chromium.googlesource.com/external/gyp.git@master