Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1506723002: X87: Revert of Provide call counts for constructor calls, surface them as a vector IC. (patchset #4… (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of Provide call counts for constructor calls, surface them as a vector IC. (patchset #4 id:60001 of https://codereview.chromium.org/1476413003/ ) port e89e08ca144693f522ddc46ffaf00d987515cc20 (r32599) original commit message: Reason for revert: Seems to be (mostly) responsible for the most recent Speedometer regression, not 100% sure. Let's see what the bots have to say. Original issue's description: > Provide call counts for constructor calls, surface them as a vector IC. > > CallIC and CallConstructStub look so alike, at least in the feedback they gather even if the implementation differs...and CallIC has such a nice way of surfacing the feedback (CallICNexus), that ther > > BUG= > > Committed: https://crrev.com/66d5a9df62da458a51e8c7ed1811dc9660f4f418 > Cr-Commit-Position: refs/heads/master@{#32452} additional description: Revert "X87: Provide call counts for constructor calls, surface them as a vector IC." as r32599 does This reverts commit 54a9d349db405b4618f1bd140c12eb2129c8ae1e. BUG= Committed: https://crrev.com/df57698cd47b8a06fbf94d5c50a0209ec796c343 Cr-Commit-Position: refs/heads/master@{#32638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +3 lines, -17 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 03:33:52 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 03:48:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506723002/1
5 years ago (2015-12-07 03:48:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 04:09:20 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 04:09:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df57698cd47b8a06fbf94d5c50a0209ec796c343
Cr-Commit-Position: refs/heads/master@{#32638}

Powered by Google App Engine
This is Rietveld 408576698