Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 1506713002: X87: Fix inobject slack tracking for both subclassing and non-subclassing cases. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix inobject slack tracking for both subclassing and non-subclassing cases. port 5d38d6819cb872e75b878864d285779959fd8e09 (r32547) original commit message: It didn't support subclassing case at all and in non-subclassing case the runtime allocation didn't do the slack tracking step. BUG= Committed: https://crrev.com/fa1b0fceca3bed04a05a0ea2f4b613e61ad208a1 Cr-Commit-Position: refs/heads/master@{#32633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -43 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +35 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 02:31:54 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 02:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506713002/1
5 years ago (2015-12-07 02:50:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 03:10:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 03:10:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa1b0fceca3bed04a05a0ea2f4b613e61ad208a1
Cr-Commit-Position: refs/heads/master@{#32633}

Powered by Google App Engine
This is Rietveld 408576698