LLVM: Add ELF Note section to NaCl object files identifying them as such to gold

test/MC/ARM/elf-note-nacl.ll

Index: test/MC/ARM/elf-note-nacl.ll
diff --git a/test/MC/ARM/elf-note-nacl.ll b/test/MC/ARM/elf-note-nacl.ll
new file mode 100644
index 0000000000000000000000000000000000000000..428d24cb990a60891c463ecb2c230f2dd79de00b
--- /dev/null
+++ b/test/MC/ARM/elf-note-nacl.ll
@@ -0,0 +1,22 @@
+; RUN: llc -filetype=obj -mtriple armv7-none-nacl-gnueabi %s -o - \
+; RUN:   | llvm-objdump -triple armv7 -s - | FileCheck %s
+
+; Tests that NaCl object files contain an ELF note section that identifies them
+; to the binutils gold linker
+
+define void @main() {
+  ret void
+}
+
+; There appears to be no way for llvm-objdump to show flags for sections, or
+; to dump groups like readelf

[Mark Seaborn, 2013/05/10 19:52:46]

Add "." at end of sentence to separate from the next line.

[Derek Schuff, 2013/05/10 22:59:26]

Done.

+; CHECK: .group
+; CHECK: .note.NaCl.ABI.arm
+; contents of the words in the note section should be:

[Mark Seaborn, 2013/05/10 19:52:46]

"The contents..." (for readability)

[Derek Schuff, 2013/05/10 22:59:26]

Done.

+; sizeof "NaCl"

[Mark Seaborn, 2013/05/10 19:52:46]

Maybe indent for readability: ';   sizeof "NaCl"'

Same for the other tests...

[Derek Schuff, 2013/05/10 22:59:26]

Done.

+; sizeof "arm"
+; 1 (NT_VERSION)
+; "NaCl" with nul termination and padding to align 4
+; "arm" with nul termination and padding to align 4
+; CHECK-NEXT: 0000 05000000 04000000 01000000 4e61436c
+; CHECK-NEXT: 0010 00000000 61726d00