Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506683004: Free one bit in Map by removing unused retaining counter. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Free one bit in Map by removing unused retaining counter. Committed: https://crrev.com/c51e4f1be4167fa463612c66266859e879000762 Cr-Commit-Position: refs/heads/master@{#32698}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -60 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +10 lines, -9 lines 0 comments Download
M src/objects.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -6 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/test-inobject-slack-tracking.cc View 11 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Igor Sheludko
PTAL
5 years ago (2015-12-08 11:34:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506683004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506683004/40001
5 years ago (2015-12-08 11:34:27 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/11058)
5 years ago (2015-12-08 12:28:25 UTC) #9
Toon Verwaest
lgtm
5 years ago (2015-12-08 14:35:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506683004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506683004/40001
5 years ago (2015-12-09 08:37:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8701)
5 years ago (2015-12-09 08:41:23 UTC) #14
Igor Sheludko
Michi, PTAL heap part.
5 years ago (2015-12-09 08:42:43 UTC) #16
Hannes Payer (out of office)
heap LGTM
5 years ago (2015-12-09 09:14:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506683004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506683004/40001
5 years ago (2015-12-09 09:17:29 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years ago (2015-12-09 09:27:40 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-09 09:27:54 UTC) #23
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c51e4f1be4167fa463612c66266859e879000762
Cr-Commit-Position: refs/heads/master@{#32698}

Powered by Google App Engine
This is Rietveld 408576698