src/IceFixups.h - Issue 1506653002: Subzero: Add Non-SFI support for x86-32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceFixups.h

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceFixups.h

diff --git a/src/IceFixups.h b/src/IceFixups.h

index a83a00e3f2ecfe6d69edc090968613481e367226..aeb0fb00539f7349f8ee39d9186240073a4779d8 100644

--- a/src/IceFixups.h

+++ b/src/IceFixups.h

@@ -44,7 +44,7 @@ public:

void set_kind(FixupKind Kind) { kind_ = Kind; }

RelocOffsetT offset() const;

- IceString symbol(const GlobalContext *Ctx) const;

+ IceString symbol(const GlobalContext *Ctx, const Assembler *Asm) const;

static const Constant *NullSymbol;

bool isNullSymbol() const { return value_ == NullSymbol; }

« no previous file with comments | « src/IceELFSection.h ('k') | src/IceFixups.cpp » ('j') | no next file with comments »