Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2010)

Unified Diff: src/IceELFObjectWriter.h

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceClFlags.cpp ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFObjectWriter.h
diff --git a/src/IceELFObjectWriter.h b/src/IceELFObjectWriter.h
index f2171b18c27e92c6ac315296cb85845bb4bb9523..58be83ca35d49e7b6e89962679105f00a16976f7 100644
--- a/src/IceELFObjectWriter.h
+++ b/src/IceELFObjectWriter.h
@@ -62,7 +62,7 @@ public:
/// RelocationKind for any relocations.
void writeDataSection(const VariableDeclarationList &Vars,
FixupKind RelocationKind,
- const IceString &SectionSuffix);
+ const IceString &SectionSuffix, bool IsPIC);
/// Copy data of a function's text section to file and note the offset of the
/// symbol's definition in the symbol table. Copy the text fixups for use
@@ -77,7 +77,8 @@ public:
template <typename ConstType> void writeConstantPool(Type Ty);
/// Write a jump table and register fixups for the target addresses.
- void writeJumpTable(const JumpTableData &JT, FixupKind RelocationKind);
+ void writeJumpTable(const JumpTableData &JT, FixupKind RelocationKind,
+ bool IsPIC);
/// Populate the symbol table with a list of external/undefined symbols.
void setUndefinedSyms(const ConstantList &UndefSyms);
@@ -153,8 +154,8 @@ private:
/// SectionType.
void writeDataOfType(SectionType SectionType,
const VariableDeclarationList &Vars,
- FixupKind RelocationKind,
- const IceString &SectionSuffix);
+ FixupKind RelocationKind, const IceString &SectionSuffix,
+ bool IsPIC);
/// Write the final relocation sections given the final symbol table. May also
/// be able to seek around the file and resolve function calls that are for
« no previous file with comments | « src/IceClFlags.cpp ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698