Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/IceAssemblerX86BaseImpl.h

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceClFlags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssemblerX86BaseImpl.h
diff --git a/src/IceAssemblerX86BaseImpl.h b/src/IceAssemblerX86BaseImpl.h
index 040fed8580741f80e0798993efa5d42ddb9bf4fe..912130a38a73346e3e7f57b8e8ef40b9e2d583b0 100644
--- a/src/IceAssemblerX86BaseImpl.h
+++ b/src/IceAssemblerX86BaseImpl.h
@@ -127,7 +127,7 @@ void AssemblerX86Base<TraitsType>::call(const ConstantRelocatable *label) {
AssemblerBuffer::EnsureCapacity ensured(&Buffer);
intptr_t call_start = Buffer.getPosition();
emitUint8(0xE8);
- emitFixup(this->createFixup(Traits::PcRelFixup, label));
+ emitFixup(this->createFixup(Traits::FK_PcRel, label));
emitInt32(-4);
assert((Buffer.getPosition() - call_start) == kCallExternalLabelSize);
(void)call_start;
@@ -138,7 +138,7 @@ void AssemblerX86Base<TraitsType>::call(const Immediate &abs_address) {
AssemblerBuffer::EnsureCapacity ensured(&Buffer);
intptr_t call_start = Buffer.getPosition();
emitUint8(0xE8);
- emitFixup(this->createFixup(Traits::PcRelFixup, AssemblerFixup::NullSymbol));
+ emitFixup(this->createFixup(Traits::FK_PcRel, AssemblerFixup::NullSymbol));
emitInt32(abs_address.value() - 4);
assert((Buffer.getPosition() - call_start) == kCallExternalLabelSize);
(void)call_start;
@@ -3098,10 +3098,11 @@ void AssemblerX86Base<TraitsType>::j(BrCond condition, Label *label,
template <typename TraitsType>
void AssemblerX86Base<TraitsType>::j(BrCond condition,
const ConstantRelocatable *label) {
+ llvm::report_fatal_error("Untested - please verify and then reenable.");
AssemblerBuffer::EnsureCapacity ensured(&Buffer);
emitUint8(0x0F);
emitUint8(0x80 + condition);
- emitFixup(this->createFixup(Traits::PcRelFixup, label));
+ emitFixup(this->createFixup(Traits::FK_PcRel, label));
emitInt32(-4);
}
@@ -3139,9 +3140,10 @@ void AssemblerX86Base<TraitsType>::jmp(Label *label, bool near) {
template <typename TraitsType>
void AssemblerX86Base<TraitsType>::jmp(const ConstantRelocatable *label) {
+ llvm::report_fatal_error("Untested - please verify and then reenable.");
AssemblerBuffer::EnsureCapacity ensured(&Buffer);
emitUint8(0xE9);
- emitFixup(this->createFixup(Traits::PcRelFixup, label));
+ emitFixup(this->createFixup(Traits::FK_PcRel, label));
emitInt32(-4);
}
« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceClFlags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698